Skip to content

Paulimer upgrade#3465

Open
orpuente-MS wants to merge 13 commits into
mainfrom
oscarpuente/paulimer-upgrade
Open

Paulimer upgrade#3465
orpuente-MS wants to merge 13 commits into
mainfrom
oscarpuente/paulimer-upgrade

Conversation

@orpuente-MS

Copy link
Copy Markdown
Contributor

This PR deletes our vendored version of paulimer and points to the latest version in crates.io instead.

Comment thread source/simulators/src/noise_config/tests.rs Dismissed
Comment thread source/simulators/src/noise_config/tests.rs Dismissed
Comment thread source/simulators/src/noise_config/tests.rs Dismissed
Comment thread source/simulators/src/noise_config/tests.rs Dismissed
Comment thread source/simulators/src/stabilizer_simulator/outcome_specific_simulation.rs Dismissed
Comment thread source/simulators/src/stabilizer_simulator/outcome_specific_simulation.rs Dismissed
@orpuente-MS orpuente-MS marked this pull request as draft July 14, 2026 17:30
Comment thread source/qdk_package/tests/test_clifford_simulator.py Dismissed
Comment thread source/qdk_package/tests/test_clifford_simulator.py Dismissed
@orpuente-MS orpuente-MS marked this pull request as ready for review July 14, 2026 18:54
Comment thread source/simulators/src/stabilizer_simulator.rs Dismissed
Comment thread Cargo.toml
Comment thread Cargo.toml
getrandom = "0.4"
iai-callgrind = "0.16.1"
# Keep the rand 0.8 transitive dependency feature-addressable for WASM builds.
getrandom_02 = { package = "getrandom", version = "0.2" }

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's annoying to have to do this "dual version of rand" hack. When I bumped rand I fixed up the vendored paulimer for it (#3239). Is it not possible for Paulimer to move forward? 0.10 has been out a while now.

@orpuente-MS orpuente-MS Jul 15, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Upgrading paulimer's rand would be a temporary fix. Once we differ in versions again, we will run into the same issue. A permanent fix would be adding a transitive "js" feature to paulimer, which would enable the "js" feature of the rand crate. That way even if we differ in versions, we wouldn't need this hack.

That been said. I don't know if:

  1. It is justifiable for paulimer to release a new version in crates.io with just a Cargo.toml change.
  2. If we are willing to wait until the next public release of paulimer to merge this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants