Paulimer upgrade#3465
Open
orpuente-MS wants to merge 13 commits into
Open
Conversation
billti
reviewed
Jul 15, 2026
billti
reviewed
Jul 15, 2026
| getrandom = "0.4" | ||
| iai-callgrind = "0.16.1" | ||
| # Keep the rand 0.8 transitive dependency feature-addressable for WASM builds. | ||
| getrandom_02 = { package = "getrandom", version = "0.2" } |
Member
There was a problem hiding this comment.
It's annoying to have to do this "dual version of rand" hack. When I bumped rand I fixed up the vendored paulimer for it (#3239). Is it not possible for Paulimer to move forward? 0.10 has been out a while now.
Contributor
Author
There was a problem hiding this comment.
Upgrading paulimer's rand would be a temporary fix. Once we differ in versions again, we will run into the same issue. A permanent fix would be adding a transitive "js" feature to paulimer, which would enable the "js" feature of the rand crate. That way even if we differ in versions, we wouldn't need this hack.
That been said. I don't know if:
- It is justifiable for paulimer to release a new version in crates.io with just a Cargo.toml change.
- If we are willing to wait until the next public release of paulimer to merge this PR.
joao-boechat
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR deletes our vendored version of paulimer and points to the latest version in crates.io instead.