Validate error code names#3453
Merged
Merged
Conversation
They should have at least two dot-delimited segments and the first should be from a known list. Add the test to the LS since it seems like it would have to depend on all the packages declaring error codes anyway.
orpuente-MS
reviewed
Jul 10, 2026
amcasey
force-pushed
the
amcasey/ErrorCodes
branch
from
9df7316 to
6ea7ff5
Compare
ScottCarda-MS
approved these changes
Jul 13, 2026
ScottCarda-MS
left a comment
ScottCarda-MS
left a comment
Contributor
There was a problem hiding this comment.
Interesting analysis of Rust source files to check for invalid error codes.
joao-boechat
approved these changes
Jul 13, 2026
joao-boechat
left a comment
joao-boechat
left a comment
Contributor
There was a problem hiding this comment.
Thanks for adding these tests, they look great! Just a couple minor suggestions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
They should have at least two dot-delimited segments and the first should be from a known list.
Add the test to the LS since it seems like it would have to depend on all the packages declaring error codes anyway.