Skip to content

feat(aria): treat frame elements like iframes in aria snapshots#41828

Merged
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:frameset-aria-snapshot
Jul 16, 2026
Merged

feat(aria): treat frame elements like iframes in aria snapshots#41828
dgozman merged 1 commit into
microsoft:mainfrom
dgozman:frameset-aria-snapshot

Conversation

@dgozman

@dgozman dgozman commented Jul 16, 2026

Copy link
Copy Markdown
Collaborator

Summary

  • <frame> elements now appear as iframe nodes in aria snapshots, and their content is stitched into ai snapshots
  • child frameset documents are stitched recursively
  • selector generation treats frames like iframes, preferring frame[name=...]/frame[title=...]

References #41784.

Frames now appear as iframe nodes in aria snapshots, their content is
stitched into ai snapshots, and child frameset documents are stitched
recursively. Selector generation treats frames like iframes as well.
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chromium] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-chromium
❌ [firefox] › mcp/cli-killall.spec.ts:42 › kill-all kills filtered dashboard pid @mcp-ubuntu-latest-firefox
❌ [webkit] › mcp/annotate.spec.ts:110 › should abort annotation when last screenshot is removed @mcp-macos-latest-webkit

7757 passed, 1249 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

3 flaky ⚠️ [chromium-library] › library/video.spec.ts:736 › screencast › should work with video+trace `@realtime-time-library-chromium-linux`
⚠️ [firefox-library] › library/inspector/cli-codegen-3.spec.ts:255 › cli codegen › should generate frame locators (4) `@firefox-ubuntu-22.04-node20`
⚠️ [firefox-page] › page/page-emulate-media.spec.ts:144 › should keep reduced motion and color emulation after reload `@firefox-ubuntu-22.04-node20`

49956 passed, 1158 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Hi, I'm the Playwright bot and I took a first look at the CI failures here.

🟢 The failures are pre-existing flakes — this PR is clear

The only real failures are 3 MCP tests, and each one flips verdict across ~250 runs on SHAs that have nothing to do with this PR. This change only touches aria-snapshot and selector-generation code, which the MCP annotate and CLI flows don't exercise.

Details

Overall: No failure traces back to this diff. The PR edits ariaSnapshot.ts, roleUtils.ts, selectorGenerator.ts, page.ts and two aria-snapshot specs — none of that reaches the failing MCP tests.

Pre-existing flake / infra

Both are MCP tests; the PR doesn't change any MCP code path, so nothing here is caused by it.

Triaged by the Playwright bot - agent run

@dgozman
dgozman merged commit 98b2ffe into microsoft:main Jul 16, 2026
45 of 48 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants