fix(server): guard invalid JSON in PageBinding.dispatch#41805
Open
SebTardif wants to merge 1 commit into
Open
Conversation
JSON.parse(payload) ran outside the try/catch, so a malformed binding payload from the page crashed the binding pipeline instead of being logged and ignored. Signed-off-by: Sebastien Tardif <sebtardif@ncf.ca>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PageBinding.dispatchparsed the binding payload withJSON.parseoutside the existing try/catch. A malformed payload from the page (or a corrupted protocol message) threw an uncaughtSyntaxErrorand aborted the binding pipeline.Fix
Parse the payload in a dedicated try/catch. On invalid JSON, log via
debugLoggerand return. When parse succeeds, the existing try/catch still delivers binding errors to the page withname/seq.Evidence (red / green)
Test plan
page-expose-function.spec.tson chromium-page