fix: avoid stale injected script installs after navigation#41788
Open
coopjyoung wants to merge 1 commit into
Open
fix: avoid stale injected script installs after navigation#41788coopjyoung wants to merge 1 commit into
coopjyoung wants to merge 1 commit into
Conversation
Author
@microsoft-github-policy-service agree |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #41773
Problem
Frame.extendInjectedScript()could continue after a navigation if the main world context promise was still pending.A stale injection request from the previous document could resolve using the new document's context, causing duplicate injected scripts.
Solution
Capture the current document before awaiting the main world context. If the frame navigated while waiting, the stale operation exits without injecting.
Testing
Added a regression test that deterministically reproduces the navigation race.
Verified: