test(proxy): fixme "should exclude patterns" on Firefox/macOS#41770
Open
microsoft-playwright-automation[bot] wants to merge 1 commit into
Open
test(proxy): fixme "should exclude patterns" on Firefox/macOS#41770microsoft-playwright-automation[bot] wants to merge 1 commit into
microsoft-playwright-automation[bot] wants to merge 1 commit into
Conversation
Times out ~35% of runs on firefox-macos-15-large (19/55) - navigating bypassed non-existent domains hangs on the Firefox/macOS CI network. Only this bot fails the test; not reproducible on other OSes or locally (0/25 with --repeat-each on macos-15-xlarge), so it is environment-specific. Scoped the fixme to firefox+macOS; the test still runs on chromium/webkit. Verified locally on macos-15-xlarge: firefox skipped, webkit still passes; npm run flint green. Fix-flakes run: https://github.com/microsoft/playwright/actions/runs/29313037253 Suggested-reviewer: dgozman
Contributor
Test results for "MCP"1 failed 7759 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"8 flaky49569 passed, 1156 skipped Merge workflow run. |
Collaborator
|
@Skn0tt It would be great to get some "preview" of the flakiness of the test we are fixing. For example, in this PR marking as "fixme" would just disable the test forever. Having some visual representation would help me to make a call whether this test adds some viable signal, or whether it is noise and should be |
Collaborator
Looks great, except for it does not fit on a single line 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Times out ~35% of runs on firefox-macos-15-large (19/55) - navigating
bypassed non-existent domains hangs on the Firefox/macOS CI network.
Only this bot fails the test; not reproducible on other OSes or locally
(0/25 with --repeat-each on macos-15-xlarge), so it is environment-specific.
Scoped the fixme to firefox+macOS; the test still runs on chromium/webkit.
Verified locally on macos-15-xlarge: firefox skipped, webkit still passes;
npm run flint green.
Fix-flakes run: https://github.com/microsoft/playwright/actions/runs/29313037253
Suggested-reviewer: dgozman