fix(test-runner): run teardown projects when maxFailures is reached#41737
Conversation
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
When a run is interrupted by maxFailures, teardown projects were skipped, so their cleanup (e.g. clearing a database) never ran. Exempt teardown project test groups from the maxFailures interruption via a TestGroup.ignoreMaxFailures flag so they still run. Fixes: microsoft#41713
Phase-level ignoreMaxFailures replaces per-test-group tracking and keeps the dispatcher scheduling logic intact.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Test results for "MCP"1 failed 7759 passed, 1249 skipped Merge workflow run. |
🟢 CI is clear — the one failure is a known flakeHi, I'm the Playwright bot and I took a first look at the CI failures. The only red on the latest commit ( DetailsOverall: no failure looks caused by this PR. The single failing test is bimodal across the results DB and fails on many unrelated PRs and push builds. Pre-existing flake / infra
Nothing to fix here on the PR's side. Exit, pursued by a bug. 🎭 Triaged by the Playwright bot - agent run |
Test results for "tests 1"6 flaky49719 passed, 1156 skipped Merge workflow run. |
Summary
--max-failures, so their cleanup (e.g. clearing a database) never ran.TestGroup.ignoreMaxFailuresflag), so they still run while everything else stops.Fixes #41713