docs(test-parallel): add guidance on shared state in parallel tests#41720
Open
yury-s wants to merge 2 commits into
Open
docs(test-parallel): add guidance on shared state in parallel tests#41720yury-s wants to merge 2 commits into
yury-s wants to merge 2 commits into
Conversation
Contributor
Test results for "MCP"2 failed 7758 passed, 1249 skipped Merge workflow run. |
Contributor
Test results for "tests 1"7 flaky49517 passed, 1161 skipped Merge workflow run. |
Collaborator
|
I am not sure this helps much as it's written. A wall of text that nobody will read. If it were to have some snippets/recipes to deal with common parallel-specific issues, that would probably be better. |
Replace the prose section with concrete before/after snippets for the common parallel-specific issues: per-test backend data, unique file paths, and avoiding module-level state that leaks between tests. Addresses review feedback on microsoft#41720.
Member
Author
|
Good call — reworked it into short recipes with snippets instead of prose (
Intro is down to one sentence. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #41671