chore(cli): migrate dashboard to playwright protocol#40143
Open
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Open
chore(cli): migrate dashboard to playwright protocol#40143Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Skn0tt wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Contributor
Test results for "MCP"1 failed 6467 passed, 383 skipped Merge workflow run. |
Contributor
Test results for "tests 1"6 flaky39154 passed, 846 skipped Merge workflow run. |
dgozman
reviewed
Apr 10, 2026
Collaborator
There was a problem hiding this comment.
Why is this called cli.ts?
| export type BrowserDescriptor = EndpointInfo & { | ||
| playwrightVersion: string; | ||
| playwrightLib: string; | ||
| playwrightClientLib: string; |
Collaborator
There was a problem hiding this comment.
Note that older versions won't have this, so you should be ready for that.
| } | ||
|
|
||
| createWebSocket(transportFactory: (url: URL) => Transport, guid?: string) { | ||
| createWebSocket(transportFactory: (url: URL) => Transport | ServerTransport, guid?: string) { |
Collaborator
There was a problem hiding this comment.
I don't quite like two types of transports. Let's make it a single one here.
| @utils/** | ||
| ../cli-client/registry.ts | ||
| ../utils/** | ||
| ../../remote/serverTransport.ts |
Collaborator
There was a problem hiding this comment.
Not sure whether this is bad with current bundles, please check with Pavel.
| entryPoints: [ | ||
| filePath('packages/playwright-client/src/cli.ts'), | ||
| ], | ||
| outfile: filePath('packages/playwright-core/lib/clientBundle.js'), |
Collaborator
There was a problem hiding this comment.
Don't we need an entry in package.json to be able to require this?
| onclose?: (cause?: string) => void; | ||
| } | ||
|
|
||
| // this entrypoint is used between dashboard and playwright-cli. |
Collaborator
There was a problem hiding this comment.
- I don't think this comment is too useful. Better explain this is the entry point to the client bundle.
- Why not use
playwright.chromium.connect()? - Should we also pass a
platforminstance?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.