Skip to content

fix(trace-viewer): align library and runner clocks by wall time#40089

Open
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
pavelfeldman:fix-40068
Open

fix(trace-viewer): align library and runner clocks by wall time#40089
pavelfeldman wants to merge 1 commit intomicrosoft:mainfrom
pavelfeldman:fix-40068

Conversation

@pavelfeldman
Copy link
Copy Markdown
Member

Summary

  • Library contexts running in a different process from the test runner (e.g. APIRequestContext over a remote run-server in Docker) have an unrelated monotonic clock.
  • The stepId-match alignment returned 0 when no action was shared, leaving the timeline to span the gap between the two process uptimes (often hours).
  • Compute the delta from the wallTime/monotonicTime pair recorded in each context-options event; fall back to stepId matching only for older traces.

Fixes #40068

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Test results for "MCP"

2 failed
❌ [firefox] › mcp/cli-test.spec.ts:23 › debug test and snapshot @mcp-windows-latest
❌ [chrome] › mcp/cli-keyboard.spec.ts:19 › press @mcp-macos-latest

6440 passed, 383 skipped


Merge workflow run.

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Test results for "tests 1"

1 failed
❌ [playwright-test] › ui-mode-test-network-tab.spec.ts:397 › should not preserve selection across test runs @macos-latest-node20

4 flaky ⚠️ [chromium-library] › library/video.spec.ts:342 › screencast › should work for popups `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:724 › screencast › should work with video+trace `@chromium-ubuntu-22.04-arm-node20`
⚠️ [chromium-library] › library/video.spec.ts:118 › screencast › should capture static page `@chromium-ubuntu-22.04-node24`
⚠️ [chromium-page] › page/page-request-continue.spec.ts:754 › propagate headers cross origin redirect after interception `@chromium-ubuntu-22.04-node20`

39142 passed, 846 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: Trace timeline Showing Hours when using APIRequestContext in fixture

1 participant