devops(driver): assemble driver from npm package and Node.js builds#3122
Open
dgozman wants to merge 2 commits into
Open
devops(driver): assemble driver from npm package and Node.js builds#3122dgozman wants to merge 2 commits into
dgozman wants to merge 2 commits into
Conversation
Download the playwright-core npm package (pinned in DRIVER_VERSION) and the official Node.js binaries (NODE_VERSION) and assemble the per-platform driver bundles, instead of cloning microsoft/playwright and building the driver from source. Mirrors playwright-dotnet. - scripts/build_driver.py replaces build_driver.sh (Python stdlib only; no Node/npm/git toolchain). setup.py invokes it per-platform on demand. - NODE_VERSION is refreshed at roll time by scripts/update_node_version.py (latest LTS, mirroring upstream's update-playwright-node.mjs). - api.json is no longer shipped in the bundle; scripts/update_api.sh generates it from a nearby microsoft/playwright checkout (PW_SRC_DIR) into a temp file and passes it to codegen via PW_API_JSON. - Drop the central build-driver CI job; each job assembles its own platform on demand, and the Lint job no longer checks out upstream.
Bump DRIVER_VERSION to 1.61.1-beta-1782139630000 and refresh NODE_VERSION to 24.17.0 (latest LTS). No public API changes between 1.61.0 and 1.61.1; the regenerated _generated.py only updates docstrings to match the current docs.
dcrousso
approved these changes
Jun 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
playwright-corenpm package (pinned inDRIVER_VERSION) and the official Node.js binaries (NODE_VERSION), instead of cloningmicrosoft/playwrightand building the driver from source. Mirrors playwright-dotnet.api.jsonis no longer shipped in the bundle;scripts/update_api.shgenerates it from a nearbymicrosoft/playwrightcheckout (PW_SRC_DIR) into a temp file and hands it to codegen viaPW_API_JSON.build-driverCI job — each job assembles its own platform on demand, and the Lint job no longer checks out upstream.1.61.1-beta-1782139630000(Node 24.17.0); no public API changes, regen only refreshes docstrings.