fix: wrap std::env::set_var in unsafe block for Rust 2024 edition#256
Merged
Conversation
iemejia
force-pushed
the
fix/unsafe-set-var
branch
from
60a4f5a to
f386cf0
Compare
std::env::set_var becomes unsafe in the Rust 2024 edition because it can cause undefined behavior when other threads are reading the environment concurrently. Add SAFETY documentation explaining why set_var is acceptable here: PostgreSQL backends are forked single-process, and the BGW tokio runtime uses new_current_thread() with no additional OS threads spawned.
iemejia
force-pushed
the
fix/unsafe-set-var
branch
from
f386cf0 to
72e1757
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split from #221 to ease review.
std::env::set_varbecomes unsafe in the Rust 2024 edition because it can cause undefined behavior when other threads read the environment concurrently.Add
SAFETYdocumentation explaining whyset_varis acceptable here: PostgreSQL backends are forked single-process, and the BGW tokio runtime usesnew_current_thread()with no additional OS threads spawned.Files:
src/worker.rs,src/client.rsTests: Purely mechanical annotation — zero behavioral change.