add dsl algorithms support to bench collective - #887
Draft
RJ Souza (Empyreus) wants to merge 20 commits into
Draft
add dsl algorithms support to bench collective#887RJ Souza (Empyreus) wants to merge 20 commits into
RJ Souza (Empyreus) wants to merge 20 commits into
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Adds multi-node DSL collective autotuning and CI coverage for AllReduce, AllGather, and ReduceScatter.
Changes:
- Compiles and tunes runtime DSL variants with configurable launch geometry.
- Adds ReduceScatter benchmarking and correctness validation.
- Reworks multi-node CI to exercise DSL collectives.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
test/deploy/run_tests.sh |
Adds manual multi-node DSL test helpers. |
python/mscclpp/default_algos/reducescatter_multi_nodes.py |
Adds a plan-generation CLI. |
python/mscclpp_benchmark/tuner.py |
Supports candidate-specific tuning dimensions. |
python/mscclpp_benchmark/correctness.py |
Validates ReduceScatter output. |
python/mscclpp_benchmark/comm.py |
Compiles and executes DSL variants. |
python/mscclpp_benchmark/bench_collective.py |
Adds DSL candidates and ReduceScatter benchmarking. |
.azure-pipelines/multi-nodes-test.yml |
Adds three multi-node DSL benchmark jobs. |
💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+306
to
+309
| for candidate in ( | ||
| *_candidate_specs(case.collective, symmetric_memory=symmetric_memory), | ||
| *_dsl_candidate_specs(comm, case.collective), | ||
| ): |
Comment on lines
+200
to
+204
| collective=collective_op, | ||
| nranks_per_node=nranks_per_node, | ||
| world_size=world_size, | ||
| in_place=True, | ||
| instances=1, |
Comment on lines
+67
to
+68
| function run_mscclpp_default_algos() | ||
| { |
| comm_group = comm.comm_group | ||
| nranks = getattr(comm_group, "nranks", 1) or 1 | ||
| nranks_per_node = getattr(comm_group, "nranks_per_node", nranks) or nranks | ||
| n_nodes = nranks // nranks_per_node if nranks_per_node else 1 |
RJ Souza (Empyreus)
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.