Use frozenset for OMML direct tag lookup#1919
Open
Amitanand983 wants to merge 1 commit into
Open
Conversation
Replace __direct_tags tuple with frozenset in oMath2Latex for O(1) membership checks in process_unknow(). No behavioral change.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Replaces
__direct_tagsfromtupletofrozensetin the DOCX OMML math converter (oMath2Latex) to improve membership lookup efficiency in a hot code path.Motivation
process_unknow()checksif stag in self.__direct_tagswhile recursively traversing OMML nodes.For math-heavy documents, this check executes frequently.
tuplemembership is linear scan: O(n)frozensetmembership is hash-based on average: O(1)frozensetis immutable liketuple, and better represents an unordered constant set used only for membership checks.Change
packages/markitdown/src/markitdown/converter_utils/docx/math/omml.py__direct_tagschanged fromtupletofrozensetValidation
pre-commit run --all-files: passed (black)hatch test: 331 passed, 4 skipped, 1 pre-existing unrelated failure (test_speech_transcription)Risk