Skip to content

fix(react-utilities): add loading to img element property whitelist #36639

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Tech Guy (lukiod) wants to merge 2 commits into
base: master
Choose a base branch
from
+37 −1
Open

fix(react-utilities): add loading to img element property whitelist #36639

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
c044e35
fix(react-utilities): add loading to img element property whitelist
lukiod Aug 27, 2026
cf060b9
Run prettier on properties.test.ts
lukiod Aug 29, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions change/@fluentui-react-utilities-2487f27f-0f06-4edf-8046-4f2016681dfd.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,7 @@
{

@github-actions github-actions Bot Aug 27, 2026 •
edited
Loading

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🕵🏾‍♀️ visual changes to review in the Visual Change Report

vr-tests-react-components/Menu Converged - submenuIndicator slotted content 2 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default - RTL.submenus open.chromium.png 404 Changed
vr-tests-react-components/Menu Converged - submenuIndicator slotted content.default.submenus open.chromium.png 413 Changed
vr-tests-react-components/Positioning 1 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/Positioning.Positioning end.updated 2 times.chromium.png 507 Changed
vr-tests-react-components/ProgressBar converged 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - Dark Mode.default.chromium.png 25 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness.default.chromium.png 27 Changed
vr-tests-react-components/ProgressBar converged.Indeterminate + thickness - High Contrast.default.chromium.png 82 Changed
vr-tests-react-components/TagPicker 3 screenshots
Image Name Diff(in Pixels) Image Type
vr-tests-react-components/TagPicker.disabled - RTL.chromium.png 635 Changed
vr-tests-react-components/TagPicker.disabled - Dark Mode.disabled input hover.chromium.png 658 Changed
vr-tests-react-components/TagPicker.disabled.chromium.png 677 Changed

There were 3 duplicate changes discarded. Check the build logs for more information.

"type": "patch",
"comment": "fix: Add loading to img element property whitelist",
"packageName": "@fluentui/react-utilities",
"email": "84954628+lukiod@users.noreply.github.com",
"dependentChangeType": "patch"
}
30 changes: 29 additions & 1 deletion packages/react-components/react-utilities/src/utils/properties.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,5 +1,12 @@
import type * as React from 'react';
import { getNativeProps, divProperties, inputProperties, anchorProperties, buttonProperties } from './properties';
import {
getNativeProps,
divProperties,
inputProperties,
anchorProperties,
buttonProperties,
imgProperties,
} from './properties';

describe('getNativeProps', () => {
it('can pass through data tags', () => {
Expand Down Expand Up @@ -113,6 +120,27 @@ describe('getNativeProps', () => {
expect(result).not.toHaveProperty('foobar');
});

it('can pass through img props including loading', () => {
const result = getNativeProps<React.ImgHTMLAttributes<HTMLImageElement>>(
{
src: 'https://example.com/image.png',
alt: 'An image',
loading: 'lazy',
// Non-img property
foobar: 1,
},
imgProperties,
);

expect(result).toMatchObject({
src: 'https://example.com/image.png',
alt: 'An image',
loading: 'lazy',
});

expect(result).not.toHaveProperty('foobar');
});

describe('popover', () => {
it('allows the popoverTarget attribute on button', () => {
const result = getNativeProps<React.HTMLAttributes<HTMLButtonElement>>(
Expand Down
1 change: 1 addition & 0 deletions packages/react-components/react-utilities/src/utils/properties.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -416,6 +416,7 @@ export const imgProperties = toObjectMap(htmlElementProperties, [
'alt', // area, img, input
'crossOrigin', // img
'height', // canvas, embed, iframe, img, input, object, video
'loading', // img, iframe
'src', // audio, embed, iframe, img, input, script, source, track, video
'srcSet', // img, source
'useMap', // img, object,
Expand Down
Loading