fix(react-headless-components-preview): descendant clicks no longer trigger dialog backdrop dismissal#36245
Merged
mainframev merged 3 commits intoMay 26, 2026
Conversation
📊 Bundle size report
🤖 This report was generated against 9317e51771e26f6142b72bb6f689aa9731218273 |
|
Pull request demo site: URL |
dmytrokirpa
reviewed
May 25, 2026
dmytrokirpa
reviewed
May 25, 2026
mainframev
changed the title
…rigger Dialog backdrop dismissal
…ef-4149-bfc7-e30efaac9d70.json Co-authored-by: Dmytro Kirpa <kirpadv@gmail.com>
…onger trigger Dialog backdrop dismissal
mainframev
force-pushed
the
fix/headless-dialog-backdrop-click-on-descendant
branch
from
922df54 to
e64f5dc
Compare
dmytrokirpa
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
EnterorSpaceon a focused<button>inside the dialog dispatched a synthetic click withclientX/Y === 0. The click bubbled to the dialog and was interpreted as a backdrop click, dialog closed before any descendant handler could run (e.g. aPopoverTriggerfailed to open its popover).Previous Behavior
Screen.Recording.2026-05-25.at.17.50.47.mov
New Behavior
DialogSurface.handleClicknow early-returns whenevent.target !== event.currentTarget. Only events that originated directly on the<dialog>element itself reach geometric check