Skip to content

Stop moving focus into the search box #821

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
lhecker merged 1 commit into from
Apr 27, 2026
+1 −4
Merged

Stop moving focus into the search box #821

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 0 additions & 1 deletion crates/edit/src/bin/edit/documents.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -282,7 +282,6 @@ impl DocumentManager {
let buffer = TextBuffer::new_rc(false)?;
{
let mut tb = buffer.borrow_mut();
tb.set_insert_final_newline(!cfg!(windows)); // As mandated by POSIX.
Copy link
Copy Markdown
Member

@DHowett DHowett Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

unrelated change - dangerous?

Copy link
Copy Markdown
Member Author

@lhecker lhecker Apr 27, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No I just moved it into the TextBuffer constructor right next to the CRLF one. A drive-by nit-improvement.

tb.set_margin_enabled(true);
tb.set_line_highlight_enabled(true);
}
Expand Down
2 changes: 0 additions & 2 deletions crates/edit/src/bin/edit/draw_editor.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -151,8 +151,6 @@ fn draw_search(ctx: &mut Context, state: &mut State) {

if change {
action = change_action;
state.wants_search.focus = true;
ctx.needs_rerender();
}
}
ctx.table_end();
Expand Down
2 changes: 1 addition & 1 deletion crates/edit/src/buffer/mod.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -316,7 +316,7 @@ impl TextBuffer {
ruler: 0,
encoding: "UTF-8",
newlines_are_crlf: cfg!(windows), // Windows users want CRLF
insert_final_newline: false,
insert_final_newline: !cfg!(windows), // As mandated by POSIX.
overtype: false,

wants_cursor_visibility: false,
Expand Down
Loading