Merged
Conversation
lhecker
added
I-bug
lhecker
commented
Apr 27, 2026
Comment on lines
+545
to
+550
| const SHIFT: u16 = 0x04; | ||
| const ALT: u16 = 0x08; | ||
| const CTRL: u16 = 0x10; | ||
| const MOTION: u16 = 0x20; | ||
| const WHEEL: u16 = 0x40; | ||
| const MODIFIERS: u16 = SHIFT | ALT | CTRL; |
Member
Author
There was a problem hiding this comment.
The code here is almost identical to before with two changes:
- Properly mask modifiers, etc., off of
btn(now calledkind) - Handle
final_bytejust in case
DHowett
reviewed
Apr 27, 2026
| m | ||
| }; | ||
| let b = self.parser.x10_mouse_buf[0] as u16 - 0x20; | ||
| let x = self.parser.x10_mouse_buf[1] as u16 - 0x20; |
Member
There was a problem hiding this comment.
i thought xterm mouse reports had a load-bearing offset of 1, and that's what this 0x21 was for?
Member
Author
There was a problem hiding this comment.
We now subtract 1 in the unified parse_xterm_mouse function!
DHowett
approved these changes
Apr 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#812 didn't properly fix dragging and mouse
inputs with modifiers. It should be solid now.