Use a random UUID for ctx.new_guid()#27
Closed
tjgreen42 wants to merge 1 commit into
Closed
Conversation
generate_guid() built UUID-shaped strings from the wall clock plus a thread-local counter, which made the returned identifiers sequential and predictable. Generate a real version-4 UUID instead. The value is produced once inside the built-in syscall activity and recorded in history, so it is still returned unchanged on replay. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ctx.new_guid() built its UUID-shaped string from the wall clock plus a thread-local counter, so the returned identifiers were sequential and predictable across calls. This switches it to a real version-4 UUID.
Replay behavior is unchanged: the value is generated once inside the built-in syscall activity and recorded in history, so the same GUID is returned on every replay. uuid was already in the dependency tree.