Stop recording registry URLs in the Functions test lockfile - #356
Open
Jamie Magee (JamieMagee) wants to merge 1 commit into
Open
Stop recording registry URLs in the Functions test lockfile#356Jamie Magee (JamieMagee) wants to merge 1 commit into
Jamie Magee (JamieMagee) wants to merge 1 commit into
Conversation
Add the test app npm setting and regenerate its lockfile without changing dependency metadata. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates the E2E Functions test app’s npm configuration and lockfile so that the lockfile no longer records registry tarball URLs (e.g., Azure Artifacts proxy hosts), keeping the lockfile portable across registries while preserving dependency versions, integrity hashes, and local file: links.
Changes:
- Add
omit-lockfile-registry-resolved=trueto the test app’s.npmrcto prevent npm from writing registryresolvedURLs into the lockfile. - Regenerate
test/e2e-functions/test-app/package-lock.jsonto remove registryresolvedfields while preserving versions/integrity and local link metadata.
Show a summary per file
| File | Description |
|---|---|
| test/e2e-functions/test-app/.npmrc | Configures npm to omit registry resolved URLs when generating/updating the lockfile. |
| test/e2e-functions/test-app/package-lock.json | Removes registry URL resolved fields to avoid committing environment-specific registry hosts while keeping dependency metadata stable. |
Review details
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Files not reviewed (1)
- test/e2e-functions/test-app/package-lock.json: Generated file
- Files reviewed: 1/2 changed files
- Comments generated: 0
- Review effort level: Lite
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Functions test app no longer records npm registry URLs in its lockfile. Dependency versions, integrity hashes, lockfile version 3, local package links, and platform metadata remain unchanged.
What changed?
omit-lockfile-registry-resolved=truetotest/e2e-functions/test-app/.npmrc.resolvedfields.Why is this change needed?
Issues / work items
Project checklist
CHANGELOG.mdAI-assisted code disclosure (required)
Was an AI tool used? (select one)
If AI was used:
.npmrc,package-lock.json, validation, commit message, and pull request descriptionresolvedfields and verified the generated result.AI verification (required if AI was used):
Testing
Automated tests
npx --yes npm@10.9.4 config get omit-lockfile-registry-resolvednpx --yes npm@10.9.4 install --package-lock-only --ignore-scripts --no-audit --no-fundnpx --yes npm@10.9.4 ci --ignore-scripts --no-audit --no-fundnpm ciat the repository rootnpm run build -w durable-functionsnpm run buildin the test appnpm testin the test app (No tests yet...)Lockfile checks:
Manual validation (only if runtime/behavior changed)
Notes for reviewers
file:dependencies, so the in-repositorydurable-functionspackage must be built before the test app build.