performance optimization#139
Open
mrjmarcelo wants to merge 27 commits into
Open
Conversation
- adapted Backend CreateTaskHub and DeleteTaskHub to call Start and Stop methods instead of directly manage backend database
…ods-implementation - implemented Backend Start and Stop methods
…s not nil and handle error from Stop method if it happens
refactoring for sqliteBackend.DeleteTaskHub just to delete db if db is not nil and handle error from Stop method if it happens
… hub method for sqlite backend
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates Durable Task Go to use time-ordered UUIDv7s and applies a few Postgres-specific changes intended to improve throughput and query performance during orchestration event and activity task processing.
Changes:
- Bumps
github.com/google/uuidto v1.6.0 and switches multiple ID generation sites to UUIDv7. - Adds a Postgres index for
Instances.ParentInstanceIDand adjusts dequeue/locking queries. - Refactors Postgres orchestration work-item retrieval to reduce time spent inside the transaction (by unmarshalling after commit).
Reviewed changes
Copilot reviewed 8 out of 9 changed files in this pull request and generated 6 comments.
Show a summary per file
| File | Description |
|---|---|
| samples/parallel/parallel.go | Uses UUIDv7 for sample device IDs. |
| internal/helpers/worker.go | Prefers UUIDv7 for default worker name uniqueness. |
| internal/helpers/history.go | Uses UUIDv7 for ExecutionId in execution-started events (with fallback). |
| go.mod | Updates github.com/google/uuid to v1.6.0. |
| go.sum | Adds v1.6.0 checksums for github.com/google/uuid. |
| client/client_grpc.go | Uses UUIDv7 for autogenerated orchestration instance IDs. |
| backend/postgres/schema.sql | Adds an index on Instances(ParentInstanceID). |
| backend/postgres/postgres.go | Updates worker name UUID, changes dequeue ordering, and refactors orchestration work-item event handling/commit timing. |
| backend/client.go | Uses UUIDv7 for autogenerated orchestration instance IDs. |
Comments suppressed due to low confidence (1)
backend/client.go:53
- This introduces a new failure mode (UUID generation can now fail the entire scheduling call). Previously this path always generated an ID; consider falling back to
uuid.NewString()on error to preserve robustness while still preferring v7 when available.
u, err := uuid.NewV7()
if err != nil {
return api.EmptyInstanceID, fmt.Errorf("failed to generate instance ID: %w", err)
}
req.InstanceId = u.String()
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
Author
|
@cgillum , please approve those changes for performance improvements |
Member
|
Hi @mrjmarcelo - thanks for opening up this PR. I've reviewed it briefly and I'm good with these changes in principle. I've triggered the CI automation just now. Please take a look at the Copilot generated comments and reply back once this is ready for a final human review. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Comment on lines
+864
to
867
| evt, err := backend.UnmarshalHistoryEvent(e.payload) | ||
| if err != nil { | ||
| return nil, err | ||
| } |
Comment on lines
832
to
833
| defer events.Close() | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
this includes changes mainly from @jeanmartins for performance optimization on events and tasks processing in durable task go.