Skip to content

Set TCP_NODELAY on pydevd client connections #2066

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
nightcityblade wants to merge 1 commit into
base: main
Choose a base branch
from
+20 −0
Open

Set TCP_NODELAY on pydevd client connections #2066

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions src/debugpy/_vendored/pydevd/_pydevd_bundle/pydevd_comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -525,6 +525,10 @@ def start_client(host, port):
s.setsockopt(socket_module.IPPROTO_TCP, socket_module.TCP_KEEPCNT, 5)
except (AttributeError, OSError):
pass # May not be available everywhere.
try:
s.setsockopt(socket_module.IPPROTO_TCP, socket_module.TCP_NODELAY, 1)
except (AttributeError, OSError):
pass # May not be available everywhere.

try:
# 10 seconds default timeout
Expand Down
16 changes: 16 additions & 0 deletions src/debugpy/_vendored/pydevd/tests_python/test_pydevd_comm.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,16 @@
from unittest import mock

from _pydevd_bundle import pydevd_comm


def test_start_client_sets_tcp_nodelay(monkeypatch):
sock = mock.Mock()
monkeypatch.setattr(pydevd_comm, "socket", lambda *_: sock)
monkeypatch.setattr(pydevd_comm.socket_module, "getaddrinfo", lambda *_: [])

assert pydevd_comm.start_client("localhost", 5678) is sock
sock.setsockopt.assert_any_call(
pydevd_comm.socket_module.IPPROTO_TCP,
pydevd_comm.socket_module.TCP_NODELAY,
1,
)