Conversation
Centralize the self-contained Linux curl/mbedTLS threading setup so consumers no longer carry private build scripts. Document the shared platform policy and system-SQLite lifecycle required when multiple embedded SDK copies coexist. Files changed: - cmake/MatsdkFetchCurl.cmake - docs/embedding-with-cmake.md Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Installed system-provider packages must support CMake versions whose FindSQLite3 module exposes SQLite::SQLite3 instead of SQLite3::SQLite3. Normalize the legacy target to the SDK's canonical target so Linux system mode remains optional and portable. Files changed: - cmake/MatsdkDependencyTargets.cmake - cmake/MSTelemetryConfig.cmake.in Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Require CMake 4.3 for builds and installed-package consumers so FindSQLite3 provides SQLite3::SQLite3 without a legacy compatibility alias. Pin CI to CMake 4.4.2 and use the newest sdkmanager release, CMake 4.1.2, for Android source builds where system SQLite discovery is not used. Files changed: root/package dependency configuration, CI workflows and setup action, Android build entry points, standalone examples/tests/wrappers, and build documentation. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
One or more issues must be addressed before approval.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 1
Open (1)
What changed in this PR
Standardizes CMake requirements, Android tooling, dependency policies, and fetched mbedTLS threading configuration across SDK consumers and CI.
Changes:
- Raises CMake requirements and pins CMake 4.1.2 for Android.
- Documents packaged dependency policies and SQLite lifecycle ownership.
- Centralizes CMake setup in CI and enables pthread-safe fetched mbedTLS.
| File | Description |
|---|---|
| wrappers/swift/CMakeLists.txt | Updated as part of this pull request. |
| wrappers/obj-c/CMakeLists.txt | Updated as part of this pull request. |
| tools/build-android-aar.sh | Updated as part of this pull request. |
| tests/vcpkg/CMakeLists.txt | Updated as part of this pull request. |
| tests/embedding/CMakeLists.txt | Updated as part of this pull request. |
| README.md | Updated as part of this pull request. |
| lib/android_build/maesdk/src/main/cpp/CMakeLists.txt | Updated as part of this pull request. |
| lib/android_build/maesdk/build.gradle | Updated as part of this pull request. |
| lib/android_build/app/src/main/cpp/CMakeLists.txt | Updated as part of this pull request. |
| lib/android_build/app/build.gradle | Updated as part of this pull request. |
| examples/objc/cocoa-app/CMakeLists.txt | Updated as part of this pull request. |
| examples/cpp/SampleCppMini/CMakeLists.txt | Updated as part of this pull request. |
| examples/cpp/SampleCpp/CMakeLists.txt | Updated as part of this pull request. |
| examples/cpp/MacProxy/CMakeLists.txt | Updated as part of this pull request. |
| examples/cpp/EventSender/CMakeLists.txt | Updated as part of this pull request. |
| examples/c/SampleC-Guest/CMakeLists.txt | Updated as part of this pull request. |
| docs/embedding-with-cmake.md | Updated as part of this pull request. |
| docs/cpp-start-android.md | Updated as part of this pull request. |
| docs/building-with-vcpkg.md | Updated as part of this pull request. |
| CMakeLists.txt | Updated as part of this pull request. |
| cmake/MSTelemetryConfig.cmake.in | Updated as part of this pull request. |
| cmake/MatsdkRequirePresetSupport.cmake | Updated as part of this pull request. |
| cmake/MatsdkOptions.cmake | Updated as part of this pull request. |
| cmake/MatsdkFetchCurl.cmake | Updated as part of this pull request. |
| build-android.cmd | Updated as part of this pull request. |
| .github/workflows/vcpkg-release-bump.yml | Updated as part of this pull request. |
| .github/workflows/test-win-latest.yml | Updated as part of this pull request. |
| .github/workflows/test-vcpkg.yml | Updated as part of this pull request. |
| .github/workflows/test-embedding.yml | Updated as part of this pull request. |
| .github/workflows/spm-release.yml | Updated as part of this pull request. |
| .github/workflows/codeql-analysis.yml | Updated as part of this pull request. |
| .github/workflows/build-ubuntu-2204.yml | Updated as part of this pull request. |
| .github/workflows/build-posix-latest.yml | Updated as part of this pull request. |
| .github/workflows/build-ios-mac.yml | Updated as part of this pull request. |
| .github/workflows/build-android.yml | Updated as part of this pull request. |
| .github/actions/setup-cmake/action.yml | Updated as part of this pull request. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Persist the pip-installed CMake binary directory through GITHUB_PATH so subsequent workflow steps use 4.4.2 instead of the runner default. Avoid the removed Android SDK 'tools' package while retaining platform-tools and the explicitly installed NDK and CMake packages. Files changed: .github/actions/setup-cmake/action.yml, .github/workflows/build-android.yml, and .github/workflows/codeql-analysis.yml. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Comment on lines
+4
to
+7
| if(CMAKE_VERSION VERSION_LESS 4.3 AND NOT CMAKE_SYSTEM_NAME STREQUAL "Android") | ||
| message(FATAL_ERROR | ||
| "MSTelemetry requires CMake 4.3 or newer. Android source builds may use " | ||
| "the Android SDK's CMake 4.1.2 package.") |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Validation
git diff --check