Skip to content

Fix version.js JScript runtime error under Windows Script Host (cscript) #1505

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
bmehta001 wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix version.js JScript runtime error under Windows Script Host (cscript) #1505

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions tools/version.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,11 @@ function generateVersionHpp() {

// Read version tag
var ver1 = readAll("..\\Solutions\\version.txt");
// Remove end-of-line
ver1 = ver1.trim();
// Remove leading/trailing whitespace. Use a regex rather than String.trim() so this
// runs under the Windows Script Host JScript engine (cscript), which does not
// implement String.prototype.trim(); the global anchored pattern also fully strips
// trailing newlines (the CodeQL incomplete-sanitization concern).
ver1 = ver1.replace(/^\s+|\s+$/g, "");
ver1 = updateYearAndDay(ver1);
// console.log("version.txt => " + ver1 + "\n");
var ver2 = ver1.split(".").join(",");
Expand Down
Loading