Fix JNI string lifetime/null-safety, Windows cancel-drain race, and UWP version parse#1494

Open

bmehta001 wants to merge 25 commits into

microsoft:mainfrom

bmehta001:bhamehta/fix-jni-windows-uwp-safety

Commits on Jun 22, 2026

Fix four latent safety bugs (JNI lifetime/null-safety, cancel race, UWP parse)

bmehta001
and
Copilot
committed
Address review comments: harden two JNI string reads

bmehta001
and
Copilot
committed

Commits on Jun 24, 2026

Guard all remaining GetStringUTFChars reads against null

bmehta001
and
Copilot
committed
Merge branch 'main' into bhamehta/fix-jni-windows-uwp-safety
bmehta001
authored

Commits on Jun 25, 2026

Commits on Jul 10, 2026

Commits on Jul 13, 2026

Avoid public timed HTTP cancel virtual

bmehta001
and
Copilot
committed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Fix JNI string lifetime/null-safety, Windows cancel-drain race, and UWP version parse#1494

Fix JNI string lifetime/null-safety, Windows cancel-drain race, and UWP version parse#1494
bmehta001 wants to merge 25 commits into
microsoft:mainfrom
bmehta001:bhamehta/fix-jni-windows-uwp-safety

Commits on Jun 22, 2026

Fix four latent safety bugs (JNI lifetime/null-safety, cancel race, UWP parse)

Address review comments: harden two JNI string reads

Commits on Jun 24, 2026

Guard all remaining GetStringUTFChars reads against null

Merge branch 'main' into bhamehta/fix-jni-windows-uwp-safety

Commits on Jun 25, 2026

Guard tenant_j for null before GetStringUTFChars in GetRecords (Copilot review)

Guard remaining jstring inputs before GetStringUTFChars (Copilot review)

GetRecords: clear pending JNI exception after tenant-token read (Copilot review)

JStringToStdString: clear pending JNI exception on failed read (Copilot review)

UWP: include <exception> directly for std::exception catch (Copilot review)

Commits on Jul 2, 2026

Merge branch 'main' into bhamehta/fix-jni-windows-uwp-safety

Commits on Jul 8, 2026

Bound the HTTP cancel drains so they cannot spin or hang (issue #1437)

Merge remote-tracking branch 'fork/bhamehta/fix-jni-windows-uwp-safety' into bhamehta/fix-jni-windows-uwp-safety

Distinguish best-effort (pause) from full-drain (teardown) HTTP cancel

Commits on Jul 9, 2026

Clear pending JNI exception before returning false in Signals_jni

Drop issue-number references from code comments

Drop issue-number reference from JniConvertors comment

Only add <condition_variable> for the new member in HttpClient_WinInet

Re-add <mutex> to HttpClient_WinInet for a self-contained header

Merge branch 'main' into bhamehta/fix-jni-windows-uwp-safety

Commits on Jul 10, 2026

Clarify that best-effort pause is only bounded on async-handler platforms

Bound best-effort pause on Windows by plumbing a deadline into CancelAllRequests

Address review: preserve CancelAllRequests() override compat and tighten the pause bound

Clarify CancelAllRequests compatibility: source-compatible, not ABI-stable

Keep the no-arg CancelAllRequests() working on every built-in client

Commits on Jul 13, 2026

Avoid public timed HTTP cancel virtual