Skip to content

fix(golang): prune unused OpenTelemetry packages - #18552

Merged
reuben olinsky (reubeno) merged 1 commit into
4.0from
mitchzhu/otel-prometheus-prune
Aug 22, 2026
Merged

fix(golang): prune unused OpenTelemetry packages#18552
reuben olinsky (reubeno) merged 1 commit into
4.0from
mitchzhu/otel-prometheus-prune

Conversation

@miz060

@miz060 Mitch Zhu (miz060) commented Aug 21, 2026

Copy link
Copy Markdown
Member

Removing the retired golang-prometheus and mwitkow conntrack components left the retained OpenTelemetry RPMs in an unsatisfiable build cycle. Azure Linux does not consume OpenTelemetry contrib or the OTel exporters, examples, and test helpers that introduce those cyclic dependencies.

Remove the unconsumed contrib component and prune the unused OTel paths before dependency generation. The OTel API and SDK capabilities consumed by Azure Linux remain available.

Validation:

  • Built the exact package release produced by this PR, golang-opentelemetry-otel-devel-1.28.0-9.azl4, against both DEV and PROD Stage 2.
  • Installed OTel 1.28.0-9 alongside the tagged gRPC 1.64.0-10 in freshly reset DEV and PROD mock chroots. Neither installation pulled the removed dependency cycle, and Go 1.26 compiled the retained OTel SDK and gRPC packages together.
  • Queried the current Azure Linux build repository before removing packages. No RPM requires any of the 72 contrib capabilities or the 40 OTel capabilities pruned here.

Copilot AI balanced review requested due to automatic review settings August 21, 2026 22:55

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Prunes unused OpenTelemetry Prometheus-related Go packages to remove dependencies on retired components and unblock Stage 2 rebuilds.

Changes:

  • Adds targeted pruning overlays for OpenTelemetry and contrib.
  • Moves customized components into dedicated definitions.
  • Refreshes locks and rendered RPM specs to release 1.28.0-9.

Reviewed changes

Copilot reviewed 7 out of 9 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/components.toml Removes inline component declarations.
base/comps/golang-opentelemetry-otel/golang-opentelemetry-otel.comp.toml Adds dedicated component definition.
base/comps/golang-opentelemetry-otel/overlays/0001-drop-unused-prometheus-exporter.overlay.toml Prunes the Prometheus exporter and example.
base/comps/golang-opentelemetry-contrib/golang-opentelemetry-contrib.comp.toml Adds dedicated component definition.
base/comps/golang-opentelemetry-contrib/overlays/0001-drop-unused-prometheus-packages.overlay.toml Prunes contrib Prometheus dependency paths.
locks/golang-opentelemetry-otel.lock Refreshes the component fingerprint.
locks/golang-opentelemetry-contrib.lock Refreshes the component fingerprint.
specs/g/golang-opentelemetry-otel/golang-opentelemetry-otel.spec Records rendered pruning and release bump.
specs/g/golang-opentelemetry-contrib/golang-opentelemetry-contrib.spec Records rendered pruning and release bump.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@miz060
Mitch Zhu (miz060) marked this pull request as ready for review August 21, 2026 23:05
@miz060
Mitch Zhu (miz060) requested a review from a team as a code owner August 21, 2026 23:05
@miz060

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.

Copilot AI review requested due to automatic review settings August 22, 2026 00:10
@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/otel-prometheus-prune branch from fe85bdf to 9a6e139 Compare August 22, 2026 00:10
@miz060 Mitch Zhu (miz060) changed the title fix(golang): prune unused OpenTelemetry Prometheus packages fix(golang): prune unused OpenTelemetry packages Aug 22, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated 1 comment.

Comment thread base/comps/components.toml
Remove the unconsumed OpenTelemetry contrib component and OTel exporters, examples, and test helpers that create cycles through gRPC and retired golang-prometheus providers.

Retain the OTel API and SDK capabilities consumed by Azure Linux.

Signed-off-by: Mitch Zhu <mitchzhu@microsoft.com>
Copilot AI review requested due to automatic review settings August 22, 2026 00:34
@miz060
Mitch Zhu (miz060) force-pushed the mitchzhu/otel-prometheus-prune branch from 9a6e139 to 187a01b Compare August 22, 2026 00:34

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 9 changed files in this pull request and generated no new comments.

@miz060

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
2 pipeline(s) were filtered out due to trigger conditions.

@reubeno
reuben olinsky (reubeno) merged commit d95150f into 4.0 Aug 22, 2026
11 checks passed
@reubeno
reuben olinsky (reubeno) deleted the mitchzhu/otel-prometheus-prune branch August 22, 2026 05:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants