feat(images): add 1p-vm-base-gen2-fips image - #18470
Closed
binujp wants to merge 1 commit into
Closed
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
Copilot stopped reviewing on behalf of
binujp due to an error
August 17, 2026 15:54
Dan Streetman (ddstreetmicrosoft)
requested changes
Aug 17, 2026
Dan Streetman (ddstreetmicrosoft)
left a comment
There was a problem hiding this comment.
issue(blocking): I have the same concerns here as in the other PR: #18468 (review)
Add the Azure Linux 4.0 1P VM Base Gen2 FIPS image with: - UEFI boot and VHD-fixed output - x86_64 and aarch64 architecture support - FIPS mode enabled through the kernel command line and dracut-fips - cloud-init and systemd-networkd networking without netplan - WALinuxAgent for Azure provisioning The image relies on package-provided cloud-init, chrony/PTP, and Hyper-V configuration, with no KIWI file injection or config.sh post-install customization. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 727c4c35-afde-4eb0-82bf-b307f6550d58
binujp
force-pushed
the
bphilip/add-marketplace-gen2-fips
branch
from
August 17, 2026 20:28
a7dba21 to
1b83f9e
Compare
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 2 out of 2 changed files in this pull request and generated no new comments.
Suppressed comments (5)
base/images/images.toml:100
- This non-distroless image is registered only as a canonical build and the KIWI definition has no matching profiles, so there is no
-devvariant that shipsazurelinux-repos-dev. That breaks the registry contract documented atbase/images/images.toml:5-27and followed byvm-baseandminimal-os. Add canonical/dev profiles and a siblingimages.1p-vm-base-gen2-fips-deventry with identical capabilities and tests.
definition = { type = "kiwi", path = "1p-vm-base-gen2-fips/1p-vm-base-gen2-fips.kiwi" }
base/images/images.toml:102
- The shared suite does not run the existing VM kernel or partition checks for this image. Those tests are auto-marked
image("vm-base"), and the matcher accepts onlyvm-baseorvm-base-*;1p-vm-base-gen2-fipstherefore skips them, which explains why a machine-bootable image can report seven skips. Add a matching image-family test directory or move generic bootable-VM checks behind themachine-bootablecapability.
{ name = "static-image-checks" },
base/images/1p-vm-base-gen2-fips/1p-vm-base-gen2-fips.kiwi:24
- The only registered test suite is offline, so the image's defining FIPS behavior is never verified after boot. A missing FIPS initramfs path or provider/policy activation would still pass these checks even with
fips=1present. Add a booted-VM smoke test that asserts/proc/sys/crypto/fips_enabledis1and validates the intended crypto provider/policy.
kernelcmdline="console=ttyS0 fips=1"
base/images/1p-vm-base-gen2-fips/1p-vm-base-gen2-fips.kiwi:39
- This architecture-specific image path is unvalidated: the PR testing only built and tested
x86_64, while the aarch64 branch selects a different console and EFI package set. Build and run the image tests for--arch aarch64before claiming aarch64 support.
<preferences arch="aarch64">
base/images/1p-vm-base-gen2-fips/1p-vm-base-gen2-fips.kiwi:70
- This local-build repository conflicts with the image registry's documented rule at
base/images/images.toml:21-23, and with the existing VM definition atbase/images/vm-base/vm-base.kiwi:82-92, which use the azl4-dev blob for local builds while Koji overrides it. Using PMC beta here makes local validation consume a different, potentially older package set than the rest of the image pipeline.
<source path="https://packages.microsoft.com/azurelinux/4.0/beta/base/$basearch" />
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Testing
azldev image build 1p-vm-base-gen2-fips --arch x86_64azldev image test 1p-vm-base-gen2-fips(9 passed, 7 skipped)AB#22820