openvmm: add new package - #18444
Conversation
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
|
I believe the SPECS check failures are because I have not uploaded the release artifacts to the spec store, jslobodzian was going to point me to instructions on how to do that. |
OpenVMM is a modular, cross-platform virtual machine monitor written in Rust. This package ships the OpenVMM host binary, which runs virtual machines on Linux via KVM or the Microsoft Hypervisor. Source0 is the archive GitHub generates for the openvmm-v<version> tag. Upstream publishes a single release asset, openvmm-<version>-vendor.tar.gz, containing the vendored crate sources and the cargo_config source replacement written by cargo vendor, so the package builds offline. The package requires rust >= 1.95, which Azure Linux 3.0 does not ship yet, so it does not build until the distribution toolchain advances. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
9a46288 to
65e07dd
Compare
Here are the instructions https://dev.azure.com/mariner-org/mariner/_wiki/wikis/mariner.wiki/1284/Source-Tar-Publishing , but I would leave that as the last step before merging (in case there's a need to amend the release sources) |
There was a problem hiding this comment.
Pull request overview
Adds OpenVMM 0.1.0 as an x86_64 package, pending the Rust 1.95 toolchain.
Changes:
- Builds OpenVMM offline from vendored Rust sources.
- Adds source integrity and component metadata.
- Registers MIT licensing metadata.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
SPECS/openvmm/openvmm.spec |
Defines the OpenVMM RPM build and installation. |
SPECS/openvmm/openvmm.signatures.json |
Records source hashes. |
LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md |
Adds OpenVMM to the license map. |
LICENSES-AND-NOTICES/SPECS/data/licenses.json |
Registers OpenVMM licensing data. |
cgmanifest.json |
Adds OpenVMM component metadata. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
| # The release profile does not emit debug info. | ||
| %global debug_package %{nil} |
Saul Paredes (Redent0r)
left a comment
There was a problem hiding this comment.
LGTM, this needs to wait for rust to be upgraded to 1.95
Merge Checklist
*-staticsubpackages, etc.) have had theirReleasetag incremented../cgmanifest.json,./toolkit/scripts/toolchain/cgmanifest.json,.github/workflows/cgmanifest.json)./LICENSES-AND-NOTICES/SPECS/data/licenses.json,./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md,./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)*.signatures.jsonfilessudo make go-tidy-allandsudo make go-test-coveragepassSummary
Adds a package for OpenVMM, a modular, cross-platform virtual machine monitor written in Rust. Ships the
openvmmhost binary.Important
Draft: this does not build on Azure Linux 3.0 yet. OpenVMM requires rust 1.95 and the distribution ships 1.90. A toolchain bump is in motion, and this is ready to move out of draft once it lands.
Built offline from the upstream release: the tag archive plus the vendor archive uploaded as a release asset.
Change Log
openvmm0.1.0Does this affect the toolchain?
NO
Test Methodology
Built in an
mcr.microsoft.com/azurelinux/base/core:3.0container from the published assets, supplying a 1.95 toolchain in place of the distribution's. Producesopenvmm-0.1.0-1.azl3.x86_64.rpm, which installs withtdnfand reportsopenvmm 0.1.0.A toolkit build has not been run, as it cannot pass until the toolchain lands.