remove(s390utils): drop s390x-only package from component list#16737
Open
christopherco wants to merge 1 commit intotomls/base/mainfrom
Open
remove(s390utils): drop s390x-only package from component list#16737christopherco wants to merge 1 commit intotomls/base/mainfrom
christopherco wants to merge 1 commit intotomls/base/mainfrom
Conversation
s390utils is an IBM Z (s390x) tool suite with no consumers on AZL: - Zero runtime dependencies: nothing Requires/Recommends/Suggests it on x86_64 or aarch64 - Not referenced in any image manifest or comps.xml - Not a build dependency of any other component - grubby's Requires on s390utils-core is gated by %ifarch s390 s390x The x86_64/aarch64 builds also produce a broken package: the main package's non-s390x codepath unconditionally Requires s390utils-se-data, but the upstream pvimg/boot Makefile skips installing SE data files when HOST_ARCH != s390x, leaving the se-data subpackage empty and unbuilt. In Fedora this works because the s390x builder produces the noarch se-data RPM which is shared across all arches; AZL has no s390x builders, so the dependency is unsatisfiable.
christopherco
requested review from
ddstreetmicrosoft and
reubeno
as code owners
Contributor
There was a problem hiding this comment.
Pull request overview
Drops the s390utils component from the base component set, aligning the build graph with AZL’s supported architectures (no s390x builders) and avoiding an unsatisfiable dependency chain caused by s390utils packaging behavior on non-s390x.
Changes:
- Remove
s390utilsfrombase/comps/components.tomlcomponent list.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
s390utils is an IBM Z (s390x) tool suite with no consumers on AZL:
The x86_64/aarch64 builds also produce a broken package: the main package's non-s390x codepath unconditionally Requires s390utils-se-data, but the upstream pvimg/boot Makefile skips installing SE data files when HOST_ARCH != s390x, leaving the se-data subpackage empty and unbuilt. In Fedora this works because the s390x builder produces the noarch se-data RPM which is shared across all arches; AZL has no s390x builders, so the dependency is unsatisfiable.
Fixes: https://dev.azure.com/mariner-org/mariner/_workitems/edit/18871