Skip to content

[docs] Update Foundry Local docs to reflect CLI-based lifecycle (aspire#17889)#1210

Open
aspire-repo-bot[bot] wants to merge 2 commits into
release/13.5from
docs/foundry-local-cli-lifecycle-pr17889-3a2c50ae50edf4b0
Open

[docs] Update Foundry Local docs to reflect CLI-based lifecycle (aspire#17889)#1210
aspire-repo-bot[bot] wants to merge 2 commits into
release/13.5from
docs/foundry-local-cli-lifecycle-pr17889-3a2c50ae50edf4b0

Conversation

@aspire-repo-bot
Copy link
Copy Markdown
Contributor

Documents changes from microsoft/aspire#17889 by @sebastienros.

Targeting release/13.4 — the latest release branch on microsoft/aspire.dev — because release/13.5 (from the source PR milestone 13.5) does not exist there.

Why this PR is needed

PR microsoft/aspire#17889 upgraded the Foundry Local integration to Microsoft.AI.Foundry.Local 1.1.0. The runtime implementation changed from using in-process FoundryLocalManager APIs to invoking the installed foundry CLI for the full service lifecycle (foundry service start, foundry service stop, foundry service list, foundry model download, foundry model load).

The existing docs stated:

"This requires the local machine to have Foundry Local installed and running."

This is now incorrect. Aspire manages the full lifecycle — users do not pre-start the service. The requirement is that the foundry CLI be installed and available on PATH.

What changed

Updated the "Use Foundry Local for development" section of azure-ai-foundry-host.mdx to:

  • Clarify that Aspire automatically starts and stops the Foundry Local service (via foundry service start / foundry service stop).
  • Remove the outdated requirement to have the service "already running".
  • State clearly that the foundry CLI must be installed and on PATH.
  • Describe the full lifecycle management (endpoint discovery, model download/load, shutdown).

Files modified

  • src/frontend/src/content/docs/integrations/cloud/azure/azure-ai-foundry/azure-ai-foundry-host.mdx — updated "Use Foundry Local for development" section

Generated by PR Documentation Check for issue #17889 · sonnet46 2.1M ·

The Foundry Local integration now uses the installed 'foundry' CLI
(foundry service start/stop/list and foundry model download/load)
instead of the FoundryLocalManager in-proc APIs. Aspire manages the
entire service lifecycle automatically.

Update docs to:
- Clarify users do not need to pre-start Foundry Local
- State that the 'foundry' CLI must be on PATH
- Describe the automatic start/stop lifecycle management

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@aspire-repo-bot aspire-repo-bot Bot added the docs-from-code Copilot initiated issue from dotnet/aspire repo label Jun 4, 2026
@aspire-repo-bot aspire-repo-bot Bot requested a review from radical June 4, 2026 00:01
@aspire-repo-bot
Copy link
Copy Markdown
Contributor Author

Frontend HTML artifact ready

The latest frontend build uploaded the frontend-dist artifact for PR #1210. Use the VS Code button below to open this PR with GitHub Artifacts Explorer and browse the built HTML locally.

VS Code: Open PR #1210 artifacts

This comment updates automatically when a new frontend build artifact is uploaded.

@IEvangelist IEvangelist changed the base branch from release/13.4 to release/13.5 June 5, 2026 20:36
@IEvangelist IEvangelist marked this pull request as ready for review June 5, 2026 21:46
@IEvangelist IEvangelist self-requested a review as a code owner June 5, 2026 21:46
Copilot AI review requested due to automatic review settings June 5, 2026 21:46
@IEvangelist IEvangelist requested a review from eerhardt as a code owner June 5, 2026 21:46
@IEvangelist IEvangelist requested a review from sebastienros June 5, 2026 21:47
Copy link
Copy Markdown
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Docs-from-code reviewer — branch mismatch, cannot verify

This PR targets release/13.5 on microsoft/aspire.dev, but microsoft/aspire has no matching release/13.5 branch (latest release branch upstream is release/13.4 at 59e06a48d2b09bc2b3efa6ac9ea6b38336b88c4b).

The referenced source PR, microsoft/aspire#17889, was merged into main as commit 6518fb56fe0cf63a23fc86767c6181352903e68c. Per this reviewer's rules I only verify against the matching release branch, so I'm skipping claim verification (Phase A) and the doc-tester run (Phase B) for this PR.

Once release/13.5 exists in microsoft/aspire (or this PR is retargeted to a branch that does exist there, e.g. release/13.4), I'll perform the full review on the next hourly run.

Head SHA reviewed: ea7d912dc61f7348d9755f4e44d4fa8a3aecfb12

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Updates the Azure AI Foundry integration documentation to reflect the newer Foundry Local behavior where Aspire manages the local service lifecycle via the installed foundry CLI (instead of requiring users to pre-start the service).

Changes:

  • Replaces the outdated “Foundry Local installed and running” prerequisite with “foundry CLI installed and on PATH”.
  • Describes Aspire-managed lifecycle steps (start, endpoint discovery, model download/load, shutdown) for Foundry Local.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Copy link
Copy Markdown
Member

@IEvangelist IEvangelist left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Source-of-truth branch mismatch — review skipped (re-review of new revision)

Cannot verify this PR against microsoft/aspire.

This is a re-review after new commits landed (ea7d912da7963b64). The branch-mismatch condition that blocked my prior review is unchanged.

PR base branch (microsoft/aspire.dev) release/13.5
Matching branch in microsoft/aspire does not exist
Latest release branch in microsoft/aspire release/13.4 (4f2189335)
Source PR cited in body microsoft/aspire#17889 — merged to main, milestone 13.5

My review protocol requires using the matching microsoft/aspire release branch as the single source of truth for claim verification. Because no release/13.5 branch exists on microsoft/aspire yet (13.5 has not been cut), I cannot verify the API/CLI/config claims in this PR against an authoritative source code snapshot for that release.

The PR body itself notes the same issue ("Targeting release/13.4 … because release/13.5 … does not exist there"), even though the actual base ended up being release/13.5 on aspire.dev. Possible resolutions:

  1. Re-target this PR to release/13.4 in aspire.dev (matches what the body already says was intended, and what currently exists upstream).
  2. Wait until release/13.5 is cut in microsoft/aspire, then re-run review against that branch.

Skipping Phase B (doc-tester) as well — running it without the Phase A claim verification would produce an incomplete review per protocol.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

docs-from-code Copilot initiated issue from dotnet/aspire repo

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants