Skip to content

.NET: accept stringified inline skill arguments #6033

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
he-yufeng wants to merge 1 commit into
base: main
Choose a base branch
from
+33 −0
Open

.NET: accept stringified inline skill arguments #6033

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 17 additions & 0 deletions dotnet/src/Microsoft.Agents.AI/Skills/Programmatic/AgentInlineSkillScript.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -92,6 +92,23 @@ private static AIFunctionArguments ConvertToFunctionArguments(JsonElement? argum
return [];
}

if (arguments.Value.ValueKind == JsonValueKind.String)
{
var text = arguments.Value.GetString();
if (!string.IsNullOrWhiteSpace(text))
{
try
{
using var document = JsonDocument.Parse(text);
arguments = document.RootElement.Clone();
}
catch (JsonException)
{
arguments = arguments.Value;
Comment on lines +105 to +107
}
}
}

if (arguments.Value.ValueKind != JsonValueKind.Object)
{
throw new InvalidOperationException(
Expand Down
16 changes: 16 additions & 0 deletions dotnet/tests/Microsoft.Agents.AI.UnitTests/AgentSkills/AgentInlineSkillScriptTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,6 +43,22 @@ public async Task RunAsync_WithParameters_PassesArgumentsAsync()
Assert.Equal(10, int.Parse(result?.ToString()!));
}

[Fact]
public async Task RunAsync_WithJsonObjectStringArguments_PassesArgumentsAsync()
{
// Arrange
var script = new AgentInlineSkillScript("add", (int a, int b) => a + b);
var skill = new AgentInlineSkill("calc-skill", "Calc.", "Instructions.");
using var argsDoc = JsonDocument.Parse("\"{\\\"a\\\":3,\\\"b\\\":7}\"");
var args = argsDoc.RootElement;
Comment on lines +52 to +53

// Act
var result = await script.RunAsync(skill, args, null, CancellationToken.None);

// Assert
Assert.Equal(10, int.Parse(result?.ToString()!));
}

[Fact]
public void ParametersSchema_NoParameters_ReturnsSchema()
{
Expand Down