.NET: Disable flaky timing-dependent integration tests#5207
Open
SergeyMenshykh wants to merge 1 commit intomicrosoft:mainfrom
Open
.NET: Disable flaky timing-dependent integration tests#5207SergeyMenshykh wants to merge 1 commit intomicrosoft:mainfrom
SergeyMenshykh wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Skip 11 flaky integration tests that fail with TaskCanceledException due to timing-dependent LLM calls in CI. Uses the existing SkipFlakyTimingTest pattern referencing issue microsoft#4971. Tests disabled: - AzureFunctions: SingleAgent, Chaining, Concurrent, Conditionals, HITL, AgentAsMcpTool - DurableTask ConsoleApp: SingleAgent, Chaining, Concurrency, Conditional - DurableTask Workflow: WorkflowAndAgents Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
SergeyMenshykh
temporarily deployed
to
integration
GitHub Actions
Inactive
github-actions
bot
changed the title
Contributor
There was a problem hiding this comment.
Pull request overview
Skips a small set of DurableTask integration tests that are failing intermittently in CI due to timing/latency variability in LLM-backed sample execution, following the existing SkipFlakyTimingTest pattern tied to issue #4971.
Changes:
- Mark 4 DurableTask
ConsoleAppSamplesValidationintegration tests as skipped usingSkipFlakyTimingTest. - Add the
SkipFlakyTimingTestskip reason constant to workflow sample validation tests and skip 1 workflow-based integration test.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/WorkflowConsoleAppSamplesValidation.cs | Introduces SkipFlakyTimingTest constant and skips the workflow+agents sample validation test. |
| dotnet/tests/Microsoft.Agents.AI.DurableTask.IntegrationTests/ConsoleAppSamplesValidation.cs | Skips four console-app sample validation tests using the existing SkipFlakyTimingTest constant. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Skip 5 flaky integration tests in DurableTask that fail with
TaskCanceledExceptiondue to timing-dependent LLM calls in CI (see run #24241294922).Uses the existing
SkipFlakyTimingTestpattern referencing #4971.Tests disabled
DurableTask ConsoleAppSamplesValidation (4 tests):
SingleAgentSampleValidationAsyncSingleAgentOrchestrationChainingSampleValidationAsyncMultiAgentConcurrencySampleValidationAsyncMultiAgentConditionalSampleValidationAsyncDurableTask WorkflowConsoleAppSamplesValidation (1 test):
WorkflowAndAgentsSampleValidationAsync