Raise METranformDrainComplete event in CHWMFT::OnDrain - #227
Open
April (linnealovespie) wants to merge 1 commit into
Open
Raise METranformDrainComplete event in CHWMFT::OnDrain#227April (linnealovespie) wants to merge 1 commit into
April (linnealovespie) wants to merge 1 commit into
Conversation
…essing output samples
April (linnealovespie)
marked this pull request as draft
May 19, 2022 18:41
April (linnealovespie)
marked this pull request as ready for review
May 19, 2022 18:41
| hr = pDrainCompleteEvent->SetUINT32(MF_EVENT_MFT_INPUT_STREAM_ID, 0); | ||
| if (FAILED(hr)) | ||
| { | ||
| break; |
There was a problem hiding this comment.
There should also be another SAFERELEASE(pDrainCompleteEvent); if this SetUINT32 method fails to prevent a memory leak
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently CHWMFT::OnDrain doesn't raise an METransformDrainComplete event when done processing all output samples, as described in the Asynchronous MFT documentation.