ci: drop Debug configuration from build and test matrices#2025
Open
tyrielv wants to merge 1 commit into
Open
Conversation
tyrielv
force-pushed
the
tyrielv/drop-debug-ci
branch
2 times, most recently
from
bc39a09 to
2c92b09
Compare
Remove Debug from the CI matrix in build, functional-test, and upgrade-test workflows, keeping only Release. This halves CI resource usage and wall-clock time for PR validation. Promote the 3 remaining Debug.Assert calls to runtime checks (InvalidOperationException / ArgumentNullException) so they fire in Release too — strictly stronger coverage than the Debug-only asserts they replace, with negligible overhead (all are on I/O or shutdown paths). Assisted-by: Claude Opus 4.6 Signed-off-by: Tyrie Vella <tyrielv@gmail.com>
tyrielv
force-pushed
the
tyrielv/drop-debug-ci
branch
from
2c92b09 to
19efa87
Compare
KeithIsSleeping
approved these changes
Jun 16, 2026
mjcheetham
approved these changes
Jun 17, 2026
mjcheetham
left a comment
mjcheetham
left a comment
Member
There was a problem hiding this comment.
This makes sense to me! The build+test against release and debug is vestigial at this point.
| using System; | ||
| using System.ComponentModel; | ||
| using System.Diagnostics; | ||
|
|
Member
There was a problem hiding this comment.
Odd to leave this as a blank line instead of just dropping. But not important.
| using GVFS.Common.Http; | ||
| using GVFS.Common.Tracing; | ||
| using System.Diagnostics; | ||
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The CI test matrix is about to get more complex: user-level install testing and arm64-native builds will each add new matrix dimensions. Before that expansion, simplify by removing the Debug configuration — which currently doubles every build and test job for minimal benefit.
What this does
Removes Debug from CI matrices in all three workflows:
build.yaml— build + unit test matrix:[Debug, Release]→[Release]functional-tests.yaml— functional test matrix:[Debug, Release]→[Release]upgrade-tests.yaml— upgrade test matrix:[Debug]→[Release]Promotes Debug.Assert to runtime checks so coverage is strictly better than before:
GitStatusCache.cs— two lock-discipline assertions →InvalidOperationExceptionQueuedPipeStringWriter.cs— queue-drained assertion →InvalidOperationExceptionMockPhysicalGitObjects.cs— null-stream assertion →ArgumentNullException.ThrowIfNullWhy Debug CI had little value here
#if DEBUGblocks in the codebase — no Debug-only code paths existDebug.Assertcalls total in production code (now promoted)DefineConstantsorCheckForOverflowUnderflowin build propsImpact