Fix accessing name on jsdoc link for invalid names - #64032
Merged
Andrew Branch (andrewbranch) merged 2 commits intoAug 27, 2026
Conversation
Member
|
Copilot what are you doing. no time to waste. hop to it please |
Copilot stopped work on behalf of
Andrew Branch (andrewbranch) due to an error
August 27, 2026 16:50
Member
|
Copilot yesterday was not your day. today is a new one full of possibility |
Co-authored-by: andrewbranch <3277153+andrewbranch@users.noreply.github.com>
Andrew Branch (andrewbranch)
marked this pull request as ready for review
August 27, 2026 17:59
Copilot started reviewing on behalf of
Andrew Branch (andrewbranch)
August 27, 2026 18:00
View session
Andrew Branch (andrewbranch)
approved these changes
Aug 27, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes invalid JSDoc links exposing a sibling node as their name.
Changes:
- Guard child lookup when a remote node has no children.
- Add regression coverage for invalid JSDoc link names.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
tools/scripts/tsc/generate-encoder.ts |
Updates generated remote-node logic. |
packages/typescript/src/api/node/node.generated.ts |
Prevents invalid child lookup. |
packages/typescript/test/sync/ast.test.ts |
Adds API regression coverage. |
💡 Add a code-review agent skill for context-aware, tailored reviews. Learn more in the docs.
Jake Bailey (jakebailey)
approved these changes
Aug 27, 2026
Copilot stopped work on behalf of
Andrew Branch (andrewbranch) due to an error
August 27, 2026 18:07
Andrew Branch (andrewbranch)
enabled auto-merge
August 27, 2026 18:59
Andrew Branch (andrewbranch)
deleted the
copilot/fix-jsdoc-link-name-access
branch
August 27, 2026 19:21
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thanks for asking me to work on this. I will get started on it and keep this PR's description up to date as I form a plan and make progress.