Skip to content

Dep updates to resolve audit issues - #3709

Open
Jake Bailey (jakebailey) wants to merge 16 commits into
microsoft:v2from
jakebailey:pnpm-audit-fixes
Open

Jake Bailey (jakebailey) wants to merge 16 commits into
microsoft:v2from
jakebailey:pnpm-audit-fixes

Conversation

@jakebailey

Copy link
Copy Markdown
Member

A slew of stuff to get us into a better audit state.

picomatch 2.3.2 fixed a ReDoS vulnerability, but in doing so stopped
matching the +(|x) extglob used by rollup-plugin-typescript2's default
include patterns. With the patched picomatch, rpt2 skips every .ts file
and the dts-cli builds fail. rpt2 0.37.0 switches to patterns that
work with both picomatch versions, which unblocks taking the security
fix.
pnpm audit reported 269 vulnerabilities, most of them in transitive
dependencies whose fixed versions are already allowed by the existing
semver ranges; the lockfile was simply holding the old versions. Moving
those to the newest compatible release clears the bulk of the report
without changing any declared dependency ranges.

sanitize-html is held at 2.17.5, since later releases require Node
22.12 and the site still builds on Node 20.
esbuild 0.27 has a low-severity advisory that is only fixed in 0.28.
The 0.28 release is marked breaking because the install script now
verifies the hash of fallback binary downloads, which does not affect
how this repo uses esbuild.
glob 13 depends on minimatch 10, which has a ReDoS advisory that is
only fixed in minimatch 11. glob 14 moves to minimatch 11.
moment 2.30.1 has a moderate advisory fixed in 2.31.0.
Node 20 reached end of life in April 2026, and the workflows were split
between Node 20 and 22. Node 24 is the newest LTS line and is supported
until April 2028. The site's build tooling has no dependency on older
Node versions, and the published packages don't declare an engines
range, so consumers are unaffected.
The earlier lockfile refresh left older copies of babel, picomatch,
yaml and a few other packages next to newer versions that also satisfy
their dependents. Collapsing them shrinks the install and keeps a
single version of each in the build.
The build runs on Node 24, so the types should describe that runtime.
Node 25 types allow APIs the build can't use, and packages that accept
any @types/node version were splitting the lockfile across several
copies. The override keeps every package on the same Node types.
sanitize-html releases after 2.17.5 fix several XSS advisories but
require Node 22.12. Now that the build runs on Node 24, the lockfile no
longer needs to hold it back.
Many direct dependencies were several minor or patch releases behind,
including jest, ts-jest, sass, and the changesets tooling. Taking those
releases keeps the toolchain current with bug fixes and makes future
upgrades smaller.

TypeScript moves to 6.0.3, for both the build and the tsconfig
reference docs, so the two stay on the same release.
esbuild-jest has been unmaintained since 2022 and drags in an old
babel-jest toolchain with vulnerable copies of braces, micromatch and
decode-uri-component. The other packages in the repo already use
ts-jest, so ata can share the same transformer.
gatsby-plugin-typegen has been unmaintained since 2022, and Gatsby 5
ships the same query type generation as a core feature. Switching to
it removes a plugin that pins its own outdated graphql-codegen stack.

The generated types live under the Queries namespace, so the few
template references to GatsbyTypes move along with them.
Gatsby pins path-to-regexp to 0.1.12, and the graphql-codegen stack
it bundles pins lodash to ~4.17.0 and immutable to ~3.7.6. All three
have patch or minor releases with security fixes and no API changes,
but the upstream ranges never allow them.

The overrides only match the vulnerable versions, so they stop having
any effect once upstream moves past them.
The override was holding sharp at 0.34.5, which has several high
severity advisories fixed only in 0.35.x. The 0.35 breaking changes
are removed deprecated APIs and a Node >= 20.9 requirement, neither
of which affects Gatsby's image or manifest plugins on Node 24.
monaco-editor and monaco-editor-core 0.56 ship a vendored copy of
DOMPurify 3.4.8, which has a series of sanitizer bypass advisories.
Monaco uses it to sanitize hover and markdown content, and the
vendored copy ends up in the playground bundle regardless of which
dompurify version the lockfile resolves.

Pointing monaco's sanitizer at the dompurify package and overriding
that package to 3.4.18 lets the bundle pick up the fixed release
until a newer monaco ships one.
The published packages only pick up devDependency updates, plus a
higher tar-fs floor in create-typescript-playground-plugin. That CLI
runs via npx, which installs the latest tar-fs anyway, so none of the
packages need a release.
@jakebailey Jake Bailey (jakebailey) added the deploy-preview Enables automatic deployments to preview environments on a PR label Nov 20, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

deploy-preview Enables automatic deployments to preview environments on a PR

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant