fix: correct heading level for Truthiness narrowing section#3581
Closed
sijie-Z wants to merge 1 commit into
Closed
fix: correct heading level for Truthiness narrowing section#3581sijie-Z wants to merge 1 commit into
sijie-Z wants to merge 1 commit into
Conversation
Changed '# Truthiness narrowing' to '## Truthiness narrowing' to fix the Table of Contents structure. The H1 heading was causing all subsequent parallel narrowing concepts to be incorrectly nested under Truthiness narrowing. Fixes #63531
Contributor
|
Duplicate of #3580. |
Author
|
Ah, didn't notice #3580 was submitted just a bit earlier! Closing this as a duplicate. Glad to see this layout bug getting fixed quickly anyway! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes microsoft/TypeScript#63531
I found the issue in packages/documentation/copy/en/handbook-v2/Narrowing.md at line 109.
The "Truthiness narrowing" section uses an H1 heading (#) instead of H2 (##), which breaks
the Table of Contents structure. All subsequent parallel narrowing concepts like "Equality
narrowing", "The in operator narrowing", "instanceof narrowing" etc. are incorrectly nested
under Truthiness narrowing in the TOC.
Changed
# Truthiness narrowingto## Truthiness narrowingto match the heading level ofother narrowing concepts in the same page.