FIX: Preserve iterative image state in Crescendo#2188
Merged
romanlutz merged 3 commits intoJul 15, 2026
Conversation
Consume seed media only after an accepted live response, route retries from the last accepted image, and distinguish cleared next-message overrides from unset values. Move gradual image disclosure into the shared Crescendo prompt and refresh the modality-feedback notebook with a live iterative run. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com> Copilot-Session: 28a92a08-f250-435a-b5c3-0715fe214cc9
rlundeen2
reviewed
Jul 14, 2026
rlundeen2
reviewed
Jul 14, 2026
rlundeen2
approved these changes
Jul 14, 2026
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…rack Address review feedback: reuse the existing factory instead of hand-constructing the placeholder MessagePiece, so there is a single source of truth for what a placeholder looks like. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix Crescendo modality feedback so original seed media is attached only until the first accepted live response. Later turns now edit the last accepted generated image, including after refusals and backtracking, while concrete one-shot prompts are not replayed indefinitely.
This also distinguishes an unset
next_messageoverride from an explicitly cleared one, exposes the actual per-turn input mode to the adversarial prompt using the same turn-aware routing as objective message construction, moves gradual image disclosure into the shared image-generation prompt, and refreshes the modality-feedback notebook with a live three-turn run.The executed notebook demonstrates:
input_mode=seed_media.Tests and Documentation
next_message=None, copied contexts, concrete and placeholder seed retries, prepended history, last-accepted-image routing, turn-aware input modes, and exhausted backtrack limits.8_modality_feedback.ipynblive, normalized it with repository hooks, and verified strict Jupytext round trips with its paired Python source.