Add missing standard library includes to screen.h#149
Open
DotChas wants to merge 1 commit intomicrosoft:mainfrom
Open
Add missing standard library includes to screen.h#149DotChas wants to merge 1 commit intomicrosoft:mainfrom
DotChas wants to merge 1 commit intomicrosoft:mainfrom
Conversation
Update screen.h by explicitly including the headers required for the types used: - <cstdint> for uint64_t - <map> for std::map - <memory> for std::shared_ptr - <string> for std::string
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi,
I was looking through the codebase and wanted to add some missing standard library includes that caught my attention in
src/display/screen.h.I added the following to make sure the file works properly on its own:
<cstdint>foruint64_t<map>forstd::map<memory>forstd::shared_ptr<string>forstd::stringNote: This PR focuses only on adding missing includes to
screen.hso it doesn't rely on other files. It doesn't check for missing includes in other header files across the project. However, some of them might be suffering from this issue as well.Thanks,
Cevdet Samed/DotChas