Fix/quick accent italian e characters#46862
Conversation
| ".m4a", | ||
| ".mp3", | ||
| ".ogg", | ||
| ".opus", |
There was a problem hiding this comment.
Remove this change, it seems not related to the title.
There was a problem hiding this comment.
Pull request overview
Fixes the Italian (IT) Quick Accent character set for the e key by removing non-accent characters, and also includes an unrelated Peek change to recognize .opus as a supported audio preview extension.
Changes:
- PowerAccent: Remove
ə(schwa) and€(Euro sign) from the Italianequick-accent list. - Peek: Add
.opusto the list of audio file extensions supported byAudioPreviewer.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
src/modules/poweraccent/PowerAccent.Core/Languages.cs |
Adjusts the Italian default quick-accent characters for VK_E to only è and é. |
src/modules/peek/Peek.FilePreviewer/Previewers/MediaPreviewer/AudioPreviewer.cs |
Adds .opus to the supported audio extension set for Peek previews. |
| ".m4a", | ||
| ".mp3", | ||
| ".ogg", | ||
| ".opus", | ||
| ".wav", |
There was a problem hiding this comment.
This PR is described as fixing the Italian Quick Accent character set, but this change adds a new supported audio extension in Peek. Please either update the PR description/title to include this Peek change (with rationale) or split it into a separate PR to keep the change atomic.
| ".m4a", | ||
| ".mp3", | ||
| ".ogg", | ||
| ".opus", |
There was a problem hiding this comment.
Adding .opus changes supported file-type behavior for Peek audio previews, but there is no automated test covering audio preview formats in Peek.UITests (TestAssets currently cover images/markdown/zip only). If this change is intended, consider adding a small .opus test asset and a UI test that asserts the preview loads (or fails gracefully) for .opus files.
The schwa (ə) is an IPA phonetic symbol, not an Italian accented letter, and is already covered by the IPA language set. The Euro sign (€) is a currency symbol and does not belong in a language-specific accent set. Italian only uses è and é as accented forms of the letter e. Fixes microsoft#46857
DaveT1991
force-pushed
the
fix/quick-accent-italian-e-characters
branch
from
db25c93 to
e0a4b20
Compare
Summary
The Italian (IT) Quick Accent set for the
ekey incorrectly included two characters:ə(schwa) — an IPA phonetic symbol, already present in the IPA language set€(Euro sign) — a currency symbol, not an accented letterStandard Italian only uses
èandéas accented forms of the letter e.Changes
Languages.cs: removed"ə"and"€"fromGetDefaultLetterKeyITVK_EcaseIssues Fixed
Fixes #46857