fix: TryAddPath exact-match check for duplicate bound operation paths#809
Merged
gavinbarron merged 3 commits intosupport/v1from Apr 14, 2026
Merged
fix: TryAddPath exact-match check for duplicate bound operation paths#809gavinbarron merged 3 commits intosupport/v1from
gavinbarron merged 3 commits intosupport/v1from
Conversation
When a duplicate path is detected in TryAddPath, the existing heuristic checks if the new operation's binding type has derived types and, if so, keeps the first entry assuming it was more specific. This is incorrect when the first entry came from a base type (e.g., directoryObject) and the new entry is the exact match for the entity set (e.g., servicePrincipal). Add an exact-match check: if the operation's binding type matches the entity set type, always replace the existing entry regardless of derived types. This ensures paths like /servicePrincipals/delta() return the correct type (servicePrincipal) instead of the base type (directoryObject). Fixes #808 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Reflection of #766 - removes obsolete tool/ build files and UpdateDocs project references that were causing build failures. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
MIchaelMainer
previously approved these changes
Apr 13, 2026
…rTests.cs Co-authored-by: Michael Mainer <8527305+MIchaelMainer@users.noreply.github.com>
|
This was referenced Apr 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #808 (OpenAPI 3.0 track of #805)
When processing bound operations,
TryAddPathcan produce incorrect return types in the generated OpenAPI specification. This happens when a base-type-bound operation (e.g.,directoryObject.delta()) is processed before a derived-type-bound operation (e.g.,servicePrincipal.delta()), and the duplicate path resolution heuristic incorrectly keeps the base type''s operation.Problem
In the Microsoft Graph v1.0 CSDL,
/servicePrincipals/delta()incorrectly returnsCollection(graph.directoryObject)instead of the correctCollection(graph.servicePrincipal).Root cause: In
TryAddPath, when a duplicate path is detected, the method checks if the new operation''s binding type has derived types. If yes, it keeps the first entry assuming it was more specific. This is wrong when the first entry came from a base type and the new entry is the exact match for the entity set.Fix
Added an exact-match check in
TryAddPath(Utils.cs): if the operation''s binding type exactly matches the entity set type (boundEntityType == operationEntityType), always replace the existing entry regardless of derived types.Changes
Utils.cs: Added exact-match guard before the existing derived-types heuristicODataPathProviderTests.cs: Added regression test that reproduces the scenario with a minimal CSDL modelTesting
All 1224 tests pass (1223 existing + 1 new regression test).