Conversation
fix: updated the local deployment changes
fix: updated multiple packages
fix: added the env variable in backend to run it locally
fix: Downmerge from main to dev-v4
There was a problem hiding this comment.
Pull request overview
This PR merges dev-v4 changes into main, focusing on Azure deployment reliability (notably Azure AI Search provisioning), dependency upgrades across Python/JS toolchains, and stricter async testing configuration.
Changes:
- Refactors Azure AI Search provisioning in
infra/main_custom.bicepto a fast-create resource + follow-up AVM module update pattern, and updates downstream references to use the update module’s outputs. - Upgrades multiple dependencies (Python:
cryptography,pytest,pytest-asyncio,requests; JS:vite,esbuildfamily) and updates corresponding lockfiles. - Enforces stricter async test behavior via
pytest.iniand updates an async test to be explicitly marked.
Reviewed changes
Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
| src/mcp_server/uv.lock | Updates locked Python deps (incl. cryptography, pytest, pytest-asyncio) and adds backports-asyncio-runner. |
| src/mcp_server/pyproject.toml | Bumps cryptography and dev test deps (pytest, pytest-asyncio). |
| src/backend/uv.lock | Moves pytest tooling into dev extras and updates locked versions (incl. cryptography, pytest, pytest-asyncio). |
| src/backend/tests/test_team_specific_methods.py | Marks async test with @pytest.mark.asyncio and adds pytest import. |
| src/backend/requirements.txt | Updates pinned versions for cryptography, pytest, pytest-asyncio. |
| src/backend/pyproject.toml | Removes pytest tooling from default deps and adds [project.optional-dependencies].dev. |
| src/backend/.env.sample | Adds AZURE_AI_PROJECT_ENDPOINT placeholder. |
| src/App/uv.lock | Updates locked Python deps used under src/App (incl. cryptography, requests). |
| src/App/package.json | Bumps vite and updates override to match. |
| src/App/package-lock.json | Updates vite and esbuild dependency graph to newer versions. |
| pytest.ini | Sets asyncio_mode = strict. |
| infra/scripts/requirements.txt | Bumps requests version. |
| infra/main_custom.bicep | Implements two-step Azure Search deployment and updates outputs/env var wiring accordingly. |
| azure_custom.yaml | Adds required minimum Bicep version (>= 0.33.0). |
Files not reviewed (1)
- src/App/package-lock.json: Language not supported
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| [project.optional-dependencies] | ||
| dev = [ | ||
| "pytest==9.0.3", | ||
| "pytest-asyncio==1.3.0", | ||
| "pytest-cov==5.0.0", | ||
| ] No newline at end of file |
There was a problem hiding this comment.
pytest, pytest-asyncio, and pytest-cov were moved into the dev extra. Any setup that runs uv sync without --extra dev (e.g., the repo’s devcontainer script) will no longer have pytest installed, which can break local test/lint workflows. Consider updating the documented/devcontainer install command to include the dev extra (or keep these as default deps if tests are expected to run in the default env).
Purpose
This pull request introduces several infrastructure and dependency updates across the Azure deployment configuration, Python requirements, test settings, and JavaScript build tooling. The main focus is on improving Azure Search Service deployment reliability, updating dependencies for security and compatibility, and ensuring stricter test isolation.
Infrastructure and Azure Resource Updates
infra/main_custom.bicepto use a two-step process: first, a direct ARM resource deployment (searchService), followed by a module update (searchServiceUpdate). This change enables managed identity and reduces deployment time. All downstream consumers now referencesearchServiceUpdatefor endpoints and outputs. [1] [2] [3] [4] [5] [6]2024-12-01-previewfor improved compatibility and access to new features.>= 0.33.0) in theazure_custom.yamlmetadata, ensuring compatibility with recent Bicep features.Dependency and Tooling Updates
requestsPython package from2.32.5to2.33.0inrequirements.txtfor security and bug fixes.vitefrom7.1.11to7.3.2and updated all@esbuild/*dependencies from0.25.12to0.27.7inpackage-lock.json, ensuring improved build performance and compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]Testing Improvements
asyncio_mode = strictinpytest.inito enforce stricter async test isolation, reducing the risk of flaky tests.Does this introduce a breaking change?
How to Test
What to Check
Verify that the following are valid
Other Information