Skip to content

fix: Dev v4 to main merge#931

Merged
Avijit-Microsoft merged 8 commits intomainfrom
dev-v4
Apr 20, 2026
Merged

fix: Dev v4 to main merge#931
Avijit-Microsoft merged 8 commits intomainfrom
dev-v4

Conversation

@Dhruvkumar-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request introduces several infrastructure and dependency updates across the Azure deployment configuration, Python requirements, test settings, and JavaScript build tooling. The main focus is on improving Azure Search Service deployment reliability, updating dependencies for security and compatibility, and ensuring stricter test isolation.

Infrastructure and Azure Resource Updates

  • Refactored the Azure Search Service deployment in infra/main_custom.bicep to use a two-step process: first, a direct ARM resource deployment (searchService), followed by a module update (searchServiceUpdate). This change enables managed identity and reduces deployment time. All downstream consumers now reference searchServiceUpdate for endpoints and outputs. [1] [2] [3] [4] [5] [6]
  • Updated the default Azure OpenAI service API version to 2024-12-01-preview for improved compatibility and access to new features.
  • Added a required minimum version for Bicep (>= 0.33.0) in the azure_custom.yaml metadata, ensuring compatibility with recent Bicep features.

Dependency and Tooling Updates

  • Upgraded the requests Python package from 2.32.5 to 2.33.0 in requirements.txt for security and bug fixes.
  • Upgraded vite from 7.1.11 to 7.3.2 and updated all @esbuild/* dependencies from 0.25.12 to 0.27.7 in package-lock.json, ensuring improved build performance and compatibility. [1] [2] [3] [4] [5] [6] [7] [8] [9] [10] [11] [12] [13] [14] [15] [16] [17] [18] [19]

Testing Improvements

  • Set asyncio_mode = strict in pytest.ini to enforce stricter async test isolation, reducing the risk of flaky tests.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR merges dev-v4 changes into main, focusing on Azure deployment reliability (notably Azure AI Search provisioning), dependency upgrades across Python/JS toolchains, and stricter async testing configuration.

Changes:

  • Refactors Azure AI Search provisioning in infra/main_custom.bicep to a fast-create resource + follow-up AVM module update pattern, and updates downstream references to use the update module’s outputs.
  • Upgrades multiple dependencies (Python: cryptography, pytest, pytest-asyncio, requests; JS: vite, esbuild family) and updates corresponding lockfiles.
  • Enforces stricter async test behavior via pytest.ini and updates an async test to be explicitly marked.

Reviewed changes

Copilot reviewed 10 out of 14 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
src/mcp_server/uv.lock Updates locked Python deps (incl. cryptography, pytest, pytest-asyncio) and adds backports-asyncio-runner.
src/mcp_server/pyproject.toml Bumps cryptography and dev test deps (pytest, pytest-asyncio).
src/backend/uv.lock Moves pytest tooling into dev extras and updates locked versions (incl. cryptography, pytest, pytest-asyncio).
src/backend/tests/test_team_specific_methods.py Marks async test with @pytest.mark.asyncio and adds pytest import.
src/backend/requirements.txt Updates pinned versions for cryptography, pytest, pytest-asyncio.
src/backend/pyproject.toml Removes pytest tooling from default deps and adds [project.optional-dependencies].dev.
src/backend/.env.sample Adds AZURE_AI_PROJECT_ENDPOINT placeholder.
src/App/uv.lock Updates locked Python deps used under src/App (incl. cryptography, requests).
src/App/package.json Bumps vite and updates override to match.
src/App/package-lock.json Updates vite and esbuild dependency graph to newer versions.
pytest.ini Sets asyncio_mode = strict.
infra/scripts/requirements.txt Bumps requests version.
infra/main_custom.bicep Implements two-step Azure Search deployment and updates outputs/env var wiring accordingly.
azure_custom.yaml Adds required minimum Bicep version (>= 0.33.0).
Files not reviewed (1)
  • src/App/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment on lines +43 to 48
[project.optional-dependencies]
dev = [
"pytest==9.0.3",
"pytest-asyncio==1.3.0",
"pytest-cov==5.0.0",
] No newline at end of file
Copy link

Copilot AI Apr 16, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pytest, pytest-asyncio, and pytest-cov were moved into the dev extra. Any setup that runs uv sync without --extra dev (e.g., the repo’s devcontainer script) will no longer have pytest installed, which can break local test/lint workflows. Consider updating the documented/devcontainer install command to include the dev extra (or keep these as default deps if tests are expected to run in the default env).

Copilot uses AI. Check for mistakes.
@Avijit-Microsoft Avijit-Microsoft merged commit 5f933ef into main Apr 20, 2026
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants