Skip to content

fix: Downmerge from main to dev-v4#929

Merged
Roopan-Microsoft merged 11 commits intodev-v4from
main
Apr 16, 2026
Merged

fix: Downmerge from main to dev-v4#929
Roopan-Microsoft merged 11 commits intodev-v4from
main

Conversation

@Dhruvkumar-Microsoft
Copy link
Copy Markdown
Collaborator

Purpose

This pull request updates the deployment workflow and notification job to improve status reporting and notification content. The main changes include adding the cleanup job status to the notification pipeline, enhancing the notification email with a summary table and configuration details, and simplifying input validation for the notification job.

Workflow and Notification Improvements:

  • The cleanup-deployment job is now executed before notifications are sent, and its result is passed to the notification job for inclusion in status reporting (.github/workflows/deploy-orchestrator.yml). [1] [2]
  • The notification job now accepts and processes a new cleanup_result input, defaulting to 'skipped', and determines a human-readable cleanup status for notifications (.github/workflows/job-send-notification.yml). [1] [2]

Notification Content Enhancements:

  • The quota failure notification email now includes a status summary table for Deployment, E2E Tests, and Cleanup, as well as configuration labels (WAF/EXP), making it easier to understand pipeline results at a glance (.github/workflows/job-send-notification.yml).

Input Validation and Job Simplification:

  • The input validation step has been removed from the notification job, streamlining the workflow and reducing redundant checks (.github/workflows/job-send-notification.yml).
  • The e2e_test_result input is now optional with a default value, improving flexibility for different pipeline triggers (.github/workflows/job-send-notification.yml).

Other Minor Updates:

  • Minor formatting changes and environment variable handling improvements were made for better maintainability (.github/workflows/job-send-notification.yml).

Overall, these changes improve the reliability and clarity of deployment notifications and ensure that cleanup status is properly tracked and reported.

Does this introduce a breaking change?

  • Yes
  • No

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
npm install
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants