migrates foundry catalog api to v2 and removes regional download/fallback#870
Open
prathikr wants to merge 2 commits into
Open
migrates foundry catalog api to v2 and removes regional download/fallback#870prathikr wants to merge 2 commits into
prathikr wants to merge 2 commits into
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the C++ SDK’s Azure Foundry catalog integration from the legacy ai.azure.com cross-region entities API to the V2 asset-gallery/v1.0/models endpoint, updating request/response modeling and associated tests.
Changes:
- Switch default catalog endpoint and filter semantics to V2 asset-gallery (
DeploymentOptions=foundryLocalDevices). - Expand catalog response modeling to include V2 fields (limits, modalities, capabilities, quantization, VRAM footprint) and map them into
ModelInfo. - Update internal API tests to validate the new request shape and response parsing behavior.
Reviewed changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| sdk_v2/cpp/test/internal_api/azure_catalog_test.cc | Updates request/response tests for the V2 asset-gallery schema and routing behavior. |
| sdk_v2/cpp/src/catalog/catalog_client.h | Updates docs to reflect new filter semantics (deploymentOptions override). |
| sdk_v2/cpp/src/catalog/azure_model_catalog.h | Updates default catalog URL and default filter for V2 asset-gallery. |
| sdk_v2/cpp/src/catalog/azure_catalog_models.h | Updates request/response type definitions for V2 schema (limits/capabilities/modalities/etc.). |
| sdk_v2/cpp/src/catalog/azure_catalog_models.cc | Implements V2 JSON parsing and maps new fields into ModelInfo. |
| sdk_v2/cpp/src/catalog/azure_catalog_client.h | Updates client docs/comments and region-routing expectations for V2 endpoint. |
| sdk_v2/cpp/src/catalog/azure_catalog_client.cc | Switches request URL/body shaping to V2 and updates filter/pagination handling. |
prathikr
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Based on the following design doc.
Known Errors:
[ FAILED ] AzureCatalogClientTest.RequestFormatMatchesKnownGood
[ FAILED ] AzureCatalogClientTest.ParsesTagsCaseInsensitively
What is happening:
In azure_catalog_client.cc:162, BuildSearchFilters has the full logic commented out and the active path only adds one filter:
VariantInformation/VariantMetadata/Device = cpuAzureCatalogClientTest.RequestFormatMatchesKnownGood expects:
AzureCatalogClientTest.ParsesTagsCaseInsensitively expects:
Resolution:
Will switch base to the full filter set once catalog models are updated with new metadata