[diskann-wide] Test unaligned loads properly.#1110
Open
hildebrandmw wants to merge 2 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR completes the diskann-wide portion of unaligned SIMD load/store support by documenting that pointer alignment is unrestricted and strengthening tests to exercise byte-level under-alignment.
Changes:
- Updates
SIMDVectorload/store documentation to remove scalar-alignment requirements. - Reworks load/store test utilities to validate every byte offset, including predicated access paths.
- Adds
bytemucktest support for safe byte-slice comparisons in test helpers.
Reviewed changes
Copilot reviewed 5 out of 6 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
diskann-wide/src/traits.rs |
Documents no alignment requirements for SIMD load/store pointers. |
diskann-wide/src/test_utils/common.rs |
Adds byte-view helpers for test buffers. |
diskann-wide/src/test_utils/load.rs |
Tests full and predicated loads at byte-level offsets. |
diskann-wide/src/test_utils/store.rs |
Tests full and predicated stores at byte-level offsets. |
diskann-wide/Cargo.toml |
Adds dev dependencies/features needed for byte casting in tests. |
Cargo.lock |
Records the new diskann-wide dev dependency. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1110 +/- ##
==========================================
- Coverage 89.46% 89.45% -0.02%
==========================================
Files 482 482
Lines 91082 91129 +47
==========================================
+ Hits 81491 81523 +32
- Misses 9591 9606 +15
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
arkrishn94
approved these changes
May 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Test under-aligned loads and stores in
diskann-wideand documents that there are no alignment restrictions on the associated pointer.This was supposed to be in #981 but somehow didn't make it into the diff.