Condition Artifact Upload to running lavapipe - #8724
Open
joaosaffran wants to merge 8 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Conditions DXC artifact uploads on whether lavapipe offload tests will run, reducing artifact storage usage.
Changes:
- Moves the offload gate before the build stage.
- Passes the gate result to the Windows artifact publishing step.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Comments suppressed due to low confidence (1)
azure-pipelines.yml:131
- Azure Pipelines condition expressions do not resolve a bare
uploadArtifactidentifier, so this condition fails to parse/evaluate instead of gating publication. Reference the mapped job variable through thevariablescontext, as the surrounding conditions do.
condition: and(succeeded(), ne(variables['artifactName'], ''), eq(variables['uploadArtifact'], 'true'))
joaosaffran
force-pushed
the
bugfix/upload-only-when-lavapipe
branch
from
July 31, 2026 01:20
dc79142 to
81455ac
Compare
joaosaffran
marked this pull request as ready for review
July 31, 2026 01:21
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Copilot reviewed 1 out of 1 changed files in this pull request and generated no new comments.
Suppressed comments (1)
azure-pipelines.yml:115
- A transient GitHub API error or unauthenticated rate limit makes
Invoke-RestMethodthrow, so this auxiliary label check now fails theVS2022_Releasebuild after its tests have passed. Catch the request failure and retain the existing false default for PRs; this skips artifact/offload work without turning core CI red.
$labels = Invoke-RestMethod "https://api.github.com/repos/$(Build.Repository.Name)/issues/$(System.PullRequest.PullRequestNumber)/labels"
Damyan Pepper (damyanp)
added
the
run-offload-tests
Damyan Pepper (damyanp)
marked this pull request as draft
August 1, 2026 00:49
Damyan Pepper (damyanp)
marked this pull request as ready for review
August 1, 2026 00:49
Damyan Pepper (damyanp)
approved these changes
Aug 4, 2026
Joshua Batista (bob80905)
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Currently we upload a new DXC artifact every time we run a test; this leads us to consume a lot more artifact storage than intended. This patch changes that so we only upload artifacts when lavapipe needs to run.