Cap highest shader model at 6.9 for the 1.9.2607 release#8618
Merged
alsepkow merged 3 commits intoJul 16, 2026
Conversation
Lower the highest recognized shader model from 6.10 to 6.9 so this release branch only produces up to Shader Model 6.9. Sets highest_minor = 9 in hctdb_instrhelp.py and regenerates the dependent sources (DxilConstants.h, DxilShaderModel.h/.cpp, HLSLOptions.td), dropping all 6.10 target profiles, the SM 6.10 table entries, and IsSM610Plus. kDxilMinor and the validator version follow at 1.9. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: f3140c6f-a4ea-4f73-aac8-df248801fd8f
damyanp
reviewed
Jul 14, 2026
damyanp
left a comment
damyanp
left a comment
Member
There was a problem hiding this comment.
LGTM.
nit: dunno if this is the language we've used in the past, but "revert" implies this might be a git revert when it isn't.
alsepkow
changed the title
Contributor
Author
|
I copied that from a previous PR. Revert highest shader model to 6.6 for Dec release by hekota · Pull Request #4108 · microsoft/DirectXShaderCompiler<#4108>
But it's a valid point. I think it's worth changing the language moving forward. Revert doesn't feel like it conveys the right meaning.
I’ll change to ‘cap’. And add that as a note to the release instructions me.
…________________________________
From: Damyan Pepper ***@***.***>
Sent: Tuesday, July 14, 2026 1:55 PM
To: microsoft/DirectXShaderCompiler ***@***.***>
Cc: Alex Sepkowski ***@***.***>; Author ***@***.***>
Subject: Re: [microsoft/DirectXShaderCompiler] Revert highest shader model to 6.9 for the 1.9.2607 release (PR #8618)
Classified as Microsoft Highly Confidential
@damyanp commented on this pull request.
LGTM.
nit: dunno if this is the language we've used in the past, but "revert" implies this might be a git revert when it isn't.
—
Reply to this email directly, view it on GitHub<#8618?email_source=notifications&email_token=ABK4EW5GL4KFYMSIRHV3CWD5E2M53A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRZHA2DMNJVHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KYZTPN52GK4S7MNWGSY3L#pullrequestreview-4698465581>, or unsubscribe<https://github.com/notifications/unsubscribe-auth/ABK4EW2EHV42C4E2KYITUQT5E2M53AVCNFSNUABEKJSXA33TNF2G64TZHM3TKNZYG44TMNR3JFZXG5LFHM2DQOBWHEZDAMJRHGQXMAQ>.
Triage notifications, keep track of coding agent tasks and review pull requests on the go with GitHub Mobile for iOS<https://github.com/notifications/mobile/ios/ABK4EW5L5HTWI5N44MWQL3D5E2M53A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRZHA2DMNJVHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2KUZTPN52GK4S7NFXXG> and Android<https://github.com/notifications/mobile/android/ABK4EW4MSRXHRMFEZMOVYCD5E2M53A5CNFSNUABKM5UWIORPF5TWS5BNNB2WEL2QOVWGYUTFOF2WK43UKJSXM2LFO4XTINRZHA2DMNJVHAY2M4TFMFZW63VGMF2XI2DPOKSWK5TFNZ2K4ZTPN52GK4S7MFXGI4TPNFSA>. Download it today!
You are receiving this because you authored the thread.
Classified as Microsoft Highly Confidential
|
joaosaffran
approved these changes
Jul 14, 2026
Collaborator
|
I figured a test would fail when making this change. |
Collaborator
|
Also, question, is this building on the previous 6.10 preview release, or is this release intended to be completely separate and not a derivative of the previous preview release? |
Capping the highest recognized shader model to 6.9 (PR microsoft#8618) removes the dxil-1-10 lit feature, so tests that target SM 6.10 or require validator version 1.10 now fail. Add REQUIRES: dxil-1-10 guards so they skip cleanly on the capped release, following the pattern from PR microsoft#8069. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: 086148ba-a82b-41c4-8fa0-5eb63e5797e2
This was referenced Jul 15, 2026
V-FEXrt
approved these changes
Jul 15, 2026
V-FEXrt
left a comment
V-FEXrt
left a comment
Collaborator
There was a problem hiding this comment.
I don't think it's for now but I'd like to have some way that we don't need to do this for releases on the SM barrier. I thought that's what the "hightest release minor" value was supposed to do but looks like that's not quite sufficient given this PR:)
alsepkow
added a commit
that referenced
this pull request
Jul 16, 2026
The PSV and DebugBreak unit tests hard-code the newest PSV runtime-info
version, which is a latent fragility unrelated to any single release.
- `ValidationTest` PSV tests hard-coded `sizeof(PSVRuntimeInfo4)` (and
the literal string `56`). That silently assumes the validator always
emits the newest PSV struct. It is wrong for any validator `< 1.10`
(which emits `PSVRuntimeInfo3`), including downlevel/external-validator
runs and any future shader-model cap. The expected size is now derived
from the validator version via a `GetExpectedPSVRuntimeInfoSize()`
helper.
- `PixTest::DebugBreakInstrumentation_{Basic,Multiple}` hard-code
`cs_6_10`; they now skip when Dxil/Validator `< 1.10`.
This is behavior-preserving on `main` (validator is 1.10 there, so PSV
v4 is still expected and the tests still run), while removing the
fragility. The latent bug was introduced in #7871, which added
`PSVRuntimeInfo4` and the `< 1.10 -> v3` gating together; main has
always run validator 1.10 since, so the `v3` path was never exercised.
Intended to be cherry-picked to `release-1.9.2607` (where #8618 caps the
validator to 1.9), unblocking the SM 6.9 cap.
Assisted by co-pilot
---------
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…m69-release-1.9.2607
alsepkow
enabled auto-merge (squash)
July 16, 2026 18:57
V-FEXrt
approved these changes
Jul 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Caps the highest recognized shader model to 6.9 by lowering from 6.10.
This is a 6.9 release.