[SPIRV] Use scalar rules for BDA alignment#8576
Open
llvm-beanz wants to merge 2 commits into
Open
Conversation
Previously the `vk::RawBufferLoad` and `vk::RawBufferStore` instructions used a default alignment of 4 unless the user explicitly specified a different value. This change instead makes the default be based on the minimum legal value for the type being loaded so that users don't need to explicitly override it when loading arbitrary data types. Fixes microsoft#8572 Assisted by Claude Opus 4.8
Contributor
|
✅ With the latest revision this PR passed the C/C++ code formatter. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Previously the
vk::RawBufferLoadandvk::RawBufferStoreinstructions used a default alignment of 4 unless the user explicitly specified a different value. This change instead makes the default be based on the minimum legal value for the type being loaded so that users don't need to explicitly override it when loading arbitrary data types.Fixes #8572
Assisted by Claude Opus 4.8