Skip to content

Set sampler feedback shader flag when sampler feedback operations are used (and validator version >= 1.9) #8567

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Icohedron wants to merge 1 commit into
base: main
Choose a base branch
from
+27 −0
Open

Set sampler feedback shader flag when sampler feedback operations are used (and validator version >= 1.9) #8567

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions lib/DXIL/DxilShaderFlags.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,6 +586,8 @@ ShaderFlags ShaderFlags::CollectShaderFlags(const Function *F,
continue;
if (hlsl::OP::IsDxilOpWave(dxilOp))
hasWaveOps = true;
if (hlsl::OP::IsDxilOpFeedback(dxilOp))
hasSamplerFeedback = true;
switch (dxilOp) {
case DXIL::OpCode::CheckAccessFullyMapped:
hasCheckAccessFully = true;
Expand Down Expand Up @@ -821,6 +823,11 @@ ShaderFlags ShaderFlags::CollectShaderFlags(const Function *F,
// Before validator version 1.8, RequiresGroup flag did not exist.
requiresGroup = false;
}
if (hasSamplerFeedback &&
DXIL::CompareVersions(valMajor, valMinor, 1, 9) < 0) {
// Before validator version 1.9, SamplerFeedback flag was not set.
hasSamplerFeedback = false;
}

flag.SetEnableDoublePrecision(hasDouble);
flag.SetStencilRef(hasStencilRef);
Expand Down
20 changes: 20 additions & 0 deletions tools/clang/test/HLSLFileCheck/hlsl/objects/FeedbackTexture/feedback_shader_flag.hlsl
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
// RUN: %dxc -E main -T ps_6_5 %s | FileCheck %s -check-prefix=FLAG
// RUN: %dxc -E main -T ps_6_5 -validator-version 1.8 %s | FileCheck %s -check-prefix=NOFLAG

// Verify that the Sampler feedback shader feature flag is set when any
// sampler feedback instruction is used, and that it is gated off for
// validator versions before 1.9.

// FLAG: Note: shader requires additional functionality:
// FLAG: Sampler feedback

// NOFLAG-NOT: Sampler feedback

FeedbackTexture2D<SAMPLER_FEEDBACK_MIN_MIP> feedbackMinMip;
Texture2D<float> texture2D;
SamplerState samp;

float main() : SV_Target {
feedbackMinMip.WriteSamplerFeedback(texture2D, samp, (float2)0);
return 0;
}
Loading