Reuse shared Unique_ASN1_OBJECT in attestation - #8437
Merged
Merged
Conversation
Co-authored-by: maxtropets <16566519+maxtropets@users.noreply.github.com>
Copilot created this pull request from a session on behalf of
Max (maxtropets)
September 23, 2026 10:10
View session
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The focused refactor preserves existing resource-management behavior and introduces no unresolved issues.
Review effort: Balanced
Findings: None
What changed in this PR
Reuses the shared OpenSSL RAII wrapper for ASN.1 objects in attestation certificate parsing.
Changes:
- Removes the duplicate local
Unique_ASN1_OBJECTalias. - Uses the shared wrapper without changing ownership or null-check behavior.
Custom instructions used: .github/copilot-instructions.md, .github/instructions/reviewing.instructions.md, and the formatting/testing skills.
| File | Description |
|---|---|
src/pal/attestation.cpp |
Replaces the local ASN.1 wrapper with the shared implementation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Max (maxtropets)
enabled auto-merge (squash)
September 23, 2026 11:36
Amaury Chamayou (achamayou)
approved these changes
Sep 23, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reuse
Unique_ASN1_OBJECTintroduced in #8378.✅ Long Test passed.